Bug 1445321 - Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander
Summary: Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 26
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alberto Ruiz
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-25 13:33 UTC by Oliver Gutiérrez
Modified: 2018-05-04 10:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-05-04 10:48:12 UTC
Type: ---
Embargoed:
aruizrui: fedora-review+


Attachments (Terms of Use)

Description Oliver Gutiérrez 2017-04-25 13:33:12 UTC
Spec URL: https://raw.githubusercontent.com/abbra/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00543607-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 1 Oliver Gutiérrez 2017-04-26 15:30:12 UTC
Updated specfile to fix bogus date: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec

Comment 2 Oliver Gutiérrez 2017-04-26 16:16:37 UTC
rpmlint output:

freeipa-desktop-profile.spec:32: W: macro-in-comment %__mkdir_p
freeipa-desktop-profile.spec:32: W: macro-in-comment %buildroot
freeipa-desktop-profile.spec:32: W: macro-in-comment %_datadir
freeipa-desktop-profile.spec:38: W: macro-in-comment %__cp
freeipa-desktop-profile.spec:38: W: macro-in-comment %buildroot
freeipa-desktop-profile.spec:38: W: macro-in-comment %_datadir
freeipa-desktop-profile.spec:65: W: macro-in-comment %_datadir
freeipa-desktop-profile.spec: W: invalid-url Source0: freeipa-desktop-profile-0.0.4.tar.gz
0 packages and 1 specfiles checked; 0 errors, 8 warnings.

Comment 3 Oliver Gutiérrez 2017-04-27 17:15:48 UTC
Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00543607-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 4 Oliver Gutiérrez 2017-04-28 11:08:31 UTC
Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544715-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 5 Oliver Gutiérrez 2017-04-28 13:37:34 UTC
Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544771-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 6 Oliver Gutiérrez 2017-04-28 14:34:55 UTC
Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544783-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 7 Oliver Gutiérrez 2017-04-28 16:20:46 UTC
Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544815-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 8 Oliver Gutiérrez 2017-04-28 16:46:10 UTC

Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544816-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.noarch.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 9 Oliver Gutiérrez 2017-04-28 16:58:09 UTC
Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544816-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 10 Oliver Gutiérrez 2017-04-28 17:23:54 UTC
Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-i386/00544824-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-2.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 11 Oliver Gutiérrez 2017-04-28 17:39:50 UTC
Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544827-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-2.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 12 Oliver Gutiérrez 2017-04-28 18:03:40 UTC
Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544832-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-2.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 13 Oliver Gutiérrez 2017-05-02 11:14:44 UTC

Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00545779-freeipa-desktop-profile/freeipa-desktop-profile-0.0.5-2.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 14 Oliver Gutiérrez 2017-05-02 11:50:12 UTC
Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-i386/00545782-freeipa-desktop-profile/freeipa-desktop-profile-0.0.5-2.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 15 Oliver Gutiérrez 2017-05-02 12:43:09 UTC
Spec URL: https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-i386/00545801-freeipa-desktop-profile/freeipa-desktop-profile-0.0.5-2.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

Comment 16 Alberto Ruiz 2017-05-04 13:21:33 UTC
Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

  The installation error is caused by a problem in the freeipa package in rawhide, the problem is well known and a bug (https://pagure.io/freeipa/issue/6927) has been filed about it. 


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 8 files have unknown license. Detailed
     output of licensecheck in /home/aruiz/1445321-freeipa-desktop-
     profile/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[-]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.4.1 starting (python version = 3.6.1)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.1
INFO: Mock Version: 1.4.1
Finish: chroot init
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.1
INFO: Mock Version: 1.4.1
Finish: chroot init
INFO: installing package(s): /home/aruiz/1445321-freeipa-desktop-profile/results/freeipa-desktop-profile-0.0.5-2.fc27.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M 31dc17bc18c74d1889bba6766a39f051 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$  --setenv=LANG=en_GB.UTF-8 --setenv=LC_MESSAGES=C /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 27 --disableplugin=local --setopt=deltarpm=false install /home/aruiz/1445321-freeipa-desktop-profile/results/freeipa-desktop-profile-0.0.5-2.fc27.noarch.rpm



Rpmlint
-------
Checking: freeipa-desktop-profile-0.0.5-2.fc27.noarch.rpm
          freeipa-desktop-profile-0.0.5-2.fc27.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.




Requires
--------
freeipa-desktop-profile (rpmlib, GLIBC filtered):
    /bin/sh
    freeipa-server-common
    python(abi)
    python2-ipaclient
    python2-ipaserver



Provides
--------
freeipa-desktop-profile:
    freeipa-desktop-profile



Source checksums
----------------
https://github.com/olivergs/freeipa-desktop-profile/releases/download/0.0.5/freeipa-desktop-profile-0.0.5.tar.gz :
  CHECKSUM(SHA256) this package     : cf8bd4bc42c972bb168f098c075afadf7104f028523896b3875b6314b6d973b6
  CHECKSUM(SHA256) upstream package : cf8bd4bc42c972bb168f098c075afadf7104f028523896b3875b6314b6d973b6


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1445321
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 17 Gwyn Ciesla 2017-05-11 14:25:20 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/freeipa-desktop-profile

Comment 18 Fedora End Of Life 2018-05-03 08:12:05 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 19 Oliver Gutiérrez 2018-05-04 10:48:12 UTC
Package has been already added to Fedora and it is being maintained by me and Alexander Bokovoy. Closing.


Note You need to log in before you can comment on or make changes to this bug.