Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1445407

Summary:	remove bug-1421590-brick-mux-reuse-ports.t
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	tests	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.10	CC:	bugs, rtalur
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1441035	Environment:
Last Closed:	2017-05-31 20:47:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1441035
Bug Blocks:	1442603

Description Atin Mukherjee 2017-04-25 15:32:40 UTC

+++ This bug was initially created as a clone of Bug #1441035 +++

Description of problem:

bug-1421590-brick-mux-reuse-ports.t seems to be a bad test to me and here is my reasoning:

This test tries to check if the ports are reused or not. When a volume is restarted, by the time glusterd tries to allocate a new port to the one of the brick processes of the volume there is no guarantee that the older port will be allocated given the kernel might take some extra time to free up the port between this time frame. From https://build.gluster.org/job/regression-test-burn-in/2932/console we can clearly see that post restart of the volume, glusterd allocated port 49153 & 49155 for brick1 & brick2 respectively but the test was expecting the ports to be matched with 49155 & 49156 which were allocated before the volume was restarted.

Version-Release number of selected component (if applicable):
mainline

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-04-10 23:57:36 EDT ---

REVIEW: https://review.gluster.org/17033 (tests: remove tests/bugs/core/bug-1421590-brick-mux-reuse-ports.t) posted (#1) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-04-12 03:09:13 EDT ---

COMMIT: https://review.gluster.org/17033 committed in master by Atin Mukherjee (amukherj) 
------
commit 1612355327fa5f86078b9dbcf7a38e4e0c63e205
Author: Atin Mukherjee <amukherj>
Date:   Tue Apr 11 09:25:48 2017 +0530

    tests: remove tests/bugs/core/bug-1421590-brick-mux-reuse-ports.t
    
    bug-1421590-brick-mux-reuse-ports.t seems to be a bad test to me and here is my
    reasoning:
    
    This test tries to check if the ports are reused or not. When a volume is
    restarted, by the time glusterd tries to allocate a new port to the one of the
    brick processes of the volume there is no guarantee that the older port will be
    allocated given the kernel might take some extra time to free up the port between
    this time frame. From
    https://build.gluster.org/job/regression-test-burn-in/2932/console we can
    clearly see that post restart of the volume, glusterd allocated port 49153 &
    49155 for brick1 & brick2 respectively but the test was expecting the ports to
    be matched with 49155 & 49156 which were allocated before the volume was
    restarted.
    
    Change-Id: Id887bf28445261d4de04fc7502e58057659c9512
    BUG: 1441035
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: https://review.gluster.org/17033
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>

Comment 1 Worker Ant 2017-04-25 15:33:15 UTC

REVIEW: https://review.gluster.org/17116 (tests: remove tests/bugs/core/bug-1421590-brick-mux-reuse-ports.t) posted (#1) for review on release-3.10 by Atin Mukherjee (amukherj)

Comment 2 Worker Ant 2017-04-27 10:52:56 UTC

COMMIT: https://review.gluster.org/17116 committed in release-3.10 by Raghavendra Talur (rtalur) 
------
commit 0a59320775ec44c472f9027b0838ad162e0e4f6c
Author: Atin Mukherjee <amukherj>
Date:   Tue Apr 11 09:25:48 2017 +0530

    tests: remove tests/bugs/core/bug-1421590-brick-mux-reuse-ports.t
    
    bug-1421590-brick-mux-reuse-ports.t seems to be a bad test to me and here is my
    reasoning:
    
    This test tries to check if the ports are reused or not. When a volume is
    restarted, by the time glusterd tries to allocate a new port to the one of the
    brick processes of the volume there is no guarantee that the older port will be
    allocated given the kernel might take some extra time to free up the port between
    this time frame. From
    https://build.gluster.org/job/regression-test-burn-in/2932/console we can
    clearly see that post restart of the volume, glusterd allocated port 49153 &
    49155 for brick1 & brick2 respectively but the test was expecting the ports to
    be matched with 49155 & 49156 which were allocated before the volume was
    restarted.
    
    >Reviewed-on: https://review.gluster.org/17033
    >Smoke: Gluster Build System <jenkins.org>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Amar Tumballi <amarts>
    >(cherry picked from commit 1612355327fa5f86078b9dbcf7a38e4e0c63e205)
    
    Change-Id: Id887bf28445261d4de04fc7502e58057659c9512
    BUG: 1445407
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: https://review.gluster.org/17116
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra Talur <rtalur>

Comment 3 Raghavendra Talur 2017-05-31 20:47:07 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.2, please open a new bug report.