Bug 1445442 – RFE more firewalling data to gather

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1445442 - RFE more firewalling data to gather

Summary:	RFE more firewalling data to gather

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	sos (Show other bugs)
Sub Component:
Version:	7.4
Hardware:	Unspecified Unspecified

Priority	unspecified Severity medium
Target Milestone:	rc
Target Release:	---
Assigned To:	Pavel Moravec
QA Contact:	Jakub Heger
Docs Contact:

URL:	https://github.com/sosreport/sos/pull...
Whiteboard:
Keywords:	FutureFeature

Depends On:
Blocks:	1473612
	Show dependency tree / graph

Reported:	2017-04-25 12:36 EDT by Tomas Dolezal
Modified:	2018-04-10 14:03 EDT (History)
CC List:	10 users (show)

See Also:
Fixed In Version:	sos-3.5-1.el7
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2018-04-10 14:01:47 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHEA-2018:0963	None	None	None	2018-04-10 14:03 EDT

Groups: None (edit)

Description Tomas Dolezal 2017-04-25 12:36:45 EDT

Description of problem:
I did use sosreport on internal testday to gather information from attendees' systems. I did however missed following data:
>network commands
 * iptables-save
 * ip6tables-save
 * ebtables-save
these commands outputs clear rule data without formatting or changes. also, ebtables are not save altogether anyhow in current 7.3 version
>firewalld:
 * /var/log/firewalld
this is a file that gets created if user adds --debug flag to firewalld sysconfig

Version-Release number of selected component (if applicable):
sos-3.4-2.el7.noarch

How reproducible:
always

Steps to Reproduce:
sosreport -o firewalld,networking,general

Actual results:
missing data from description above

Expected results:


Additional info:
firewalld log could be missing

Comment 2 Pavel Moravec 2017-04-25 14:19:36 EDT

RHEL7.4 devel phase finished a month ago, rescheduling to 7.5.

I guess the [ip|ip6|eb]tables-save are required since:
- "iptables -L" output has running config not the saved one
- /etc/sysconfig/iptables-config lacks firewalld-stored info (contrary to RHEL6 where the rules were appended there)

/var/log/firewalld makes sense to collect, sure.

Comment 3 Bryn M. Reeves 2017-04-25 14:52:38 EDT

The *tables-save commands write the configuration out from the live data (iow the information is equal to -L). The difference is that the lines are in iptables command format to re-create the table: "-A <chain> ... -j <target>"

We do currently collect this, but only for non-default netns namespaces.

It's easy enough to add if it's really required but excepting the formatting differences this information should already be in a default report.

The firewalld debug logs should be added.

Comment 4 Thomas Woerner 2017-05-03 07:28:46 EDT

sos currently seems to only collect information about the filter, nat and mangle tables for IPv4 and IPv6. This needs to be extended by using the table information from /proc/net/ip_tables_names for IPv4 and /proc/net/ip6_tables_names for IPv6.

Using the -save commands all rules in all used tables will be added to the report. This information can be used easily for tests without the need to manually rebuild the rule set from the list output.

Comment 5 Pavel Moravec 2017-09-05 16:24:12 EDT

/var/log/firewalld is to be collected, together with 

ip[|6]tables -t <any_table_from_the_/proc/net_file>

The -save commands are rather about collecting same data but in different format - we try to avoid gathering same data multiple times just in different format.

Rather there should be a script (or a tool for sosreport to "add" more such outputs, like for https://bugzilla.redhat.com/show_bug.cgi?id=1483926) that converts the data collected by sos to another required format.

(if you feel upstream could accept also collecting the -save cmds outputs, please open upstream issue in https://github.com/sosreport/sos/issues to discuss it there)

Comment 6 Pavel Moravec 2017-11-02 10:52:21 EDT

Steve,
could you please pm_ack+ this FutureFeature ? The codechange newly collects firewalld / iptables rules for _all_ loaded modules.

Thanks.

Comment 7 Pavel Moravec 2017-11-03 09:40:25 EDT

Raising needinfo for pm_ack+ (see #c6)

Comment 8 Pavel Moravec 2017-11-03 15:24:34 EDT

modified due to rebase of sos to 3.5

Comment 15 errata-xmlrpc 2018-04-10 14:01:47 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0963

Note You need to log in before you can comment on or make changes to this bug.