Bug 1445829 - Valgrind cannot decode some ADCX and ADOX instructions
Summary: Valgrind cannot decode some ADCX and ADOX instructions
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: valgrind
Version: 25
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Mark Wielaard
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-26 15:24 UTC by Jeffrey Walton
Modified: 2017-12-12 10:11 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-12 10:11:06 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
KDE Software Compilation 360415 0 None None None 2017-04-26 15:44:09 UTC

Description Jeffrey Walton 2017-04-26 15:24:36 UTC
Valgrind cannot decode some ADCX and ADOX instructions. The issue was encountered on a 6th gen Skylake when using the Clang compiler on a C++ program with -std=c++03 and -std=c++11.

The upstream bug report is located at https://bugs.kde.org/show_bug.cgi?id=360415.

$ cat test.c
#include <stdint.h>

int main(int argc, char* argv[])
{
    uint32_t a = argc*4, b = argc*8;
    asm ("adcxl %1, %0" : "+r"(a) : "rm"(b));
    return a;
}

$ gcc test.c -o test.exe

$ /usr/bin/valgrind ./test.exe
==15504== Memcheck, a memory error detector
==15504== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.
==15504== Using Valgrind-3.12.0 and LibVEX; rerun with -h for copyright info
==15504== Command: ./test.exe
==15504==
vex amd64->IR: unhandled instruction bytes: 0x66 0xF 0x38 0xF6 0x45 0xF8 0x89 0x45 0xFC 0x8B
vex amd64->IR:   REX=0 REX.W=0 REX.R=0 REX.X=0 REX.B=0
vex amd64->IR:   VEX=0 VEX.L=0 VEX.nVVVV=0x0 ESC=0F38
vex amd64->IR:   PFX.66=1 PFX.F2=0 PFX.F3=0
==15504== valgrind: Unrecognised instruction at address 0x4004c6.
==15504==    at 0x4004C6: main (in /home/test/test.exe)
==15504== Your program just tried to execute an instruction that Valgrind
==15504== did not recognise.  There are two possible reasons for this.
==15504== 1. Your program has a bug and erroneously jumped to a non-code
==15504==    location.  If you are running Memcheck and you just saw a
==15504==    warning about a bad jump, it's probably your program's fault.
==15504== 2. The instruction is legitimate but Valgrind doesn't handle it,
==15504==    i.e. it's Valgrind's fault.  If you think this is the case or
==15504==    you are not sure, please let us know and we'll try to fix it.
==15504== Either way, Valgrind will now raise a SIGILL signal which will
==15504== probably kill your program.
==15504==
==15504== Process terminating with default action of signal 4 (SIGILL)
==15504==  Illegal opcode at address 0x4004C6
==15504==    at 0x4004C6: main (in /home/test/test.exe)
==15504==
==15504== HEAP SUMMARY:
==15504==     in use at exit: 0 bytes in 0 blocks
==15504==   total heap usage: 0 allocs, 0 frees, 0 bytes allocated
==15504==
==15504== All heap blocks were freed -- no leaks are possible
==15504==
==15504== For counts of detected and suppressed errors, rerun with: -v
==15504== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
Illegal instruction (core dumped)

And:

$ gcc -O1 test.c -c
skylake:cryptopp$ objdump --disassemble test.o

test.o:     file format elf64-x86-64

Disassembly of section .text:

0000000000000000 <main>:
   0:   8d 04 bd 00 00 00 00    lea    0x0(,%rdi,4),%eax
   7:   c1 e7 03                shl    $0x3,%edi
   a:   66 0f 38 f6 c7          adcx   %edi,%eax
   f:   c3                      retq


**********

Valgrind has a patch to decode ADCX and ADOX for version 3.12, but it has not been applied to 3.12 or 3.13. Also see https://bugs.kde.org/show_bug.cgi?id=360415.

Building Valgrind from sources after applying the patch manually results in success.

  svn co svn://svn.valgrind.org/valgrind/trunk valgrind
  cd valgrind

  wget https://bugsfiles.kde.org/attachment.cgi?id=105193 -O adcx.patch
  cd VEX

  svn patch ../adcx.patch
  cd ..

  ./autogen.sh
  ./configure --prefix=...
  make
  make install


**********

$ lsb_release -a
LSB Version:    :core-4.1-amd64:core-4.1-noarch
Distributor ID: Fedora
Description:    Fedora release 25 (Twenty Five)
Release:        25
Codename:       TwentyFive

$ dnf info valgrind.x86_64
Last metadata expiration check: 2 days, 4:24:31 ago on Mon Apr 24 06:32:49 2017.
Installed Packages
Name        : valgrind
Arch        : x86_64
Epoch       : 1
Version     : 3.12.0
Release     : 1.fc25
Size        : 26 M
Repo        : @System
From repo   : fedora
...

$ cat /proc/cpuinfo
processor       : 0
vendor_id       : GenuineIntel
cpu family      : 6
model           : 94
model name      : Intel(R) Core(TM) i5-6400 CPU @ 2.70GHz
stepping        : 3
microcode       : 0x9e
cpu MHz         : 899.945
cache size      : 6144 KB
physical id     : 0
siblings        : 4
core id         : 0
cpu cores       : 4
apicid          : 0
initial apicid  : 0
fpu             : yes
fpu_exception   : yes
cpuid level     : 22
wp              : yes
flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch intel_pt tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx rdseed adx smap clflushopt xsaveopt xsavec xgetbv1 xsaves dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp
bugs            :
bogomips        : 5424.00
clflush size    : 64
cache_alignment : 64
address sizes   : 39 bits physical, 48 bits virtual
power management:
...

Comment 1 Mark Wielaard 2017-04-26 17:47:10 UTC
Have you tried building with the normal gcc system compiler?

There is a proposed patch in the upstream bug, but that hasn't been accepted yet.
Any idea why that is? Normally we don't take patches that aren't upstream.

Comment 2 Jeffrey Walton 2017-04-26 18:12:36 UTC
(In reply to Mark Wielaard from comment #1)
> Have you tried building with the normal gcc system compiler?

Yes, both GCC and Clang build the real program and the reproducer. Clang happens to select the ADCX instruction, which exposes the Valgrind bug.

(The real program is Wei Dai's Crypto++. We don't control which compiler a user selects in the field).

> There is a proposed patch in the upstream bug, but that hasn't been accepted
> yet.
> Any idea why that is? Normally we don't take patches that aren't upstream.

I'm not sure why the patch was not accepted. Since you and I both wonder why it was not accepted, maybe its time to ask them. I did not ask when I added the "mee too" because I did not want to appear to be prying into their affairs.

Comment 3 Fedora End Of Life 2017-11-16 19:34:41 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 4 Fedora End Of Life 2017-12-12 10:11:06 UTC
Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.