SPEC: http://www.matthias-runge.de/fedora/python-fluent-logger.spec SRPM: http://www.matthias-runge.de/fedora/python-fluent-logger-0.5.0-1.fc25.src.rpm rpmlint ./python-fluent-logger.spec ../SRPMS/python-fluent-logger-0.5.0-1.fc25.src.rpm ./python-fluent-logger.spec:18: W: macro-in-comment %{pypi_name} ./python-fluent-logger.spec:18: W: macro-in-comment %{pypi_name} ./python-fluent-logger.spec:18: W: macro-in-comment %{version} python-fluent-logger.src: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out python-fluent-logger.src: W: spelling-error %description -l en_US Fluentd -> Fluent, Fluent d python-fluent-logger.src:18: W: macro-in-comment %{pypi_name} python-fluent-logger.src:18: W: macro-in-comment %{pypi_name} python-fluent-logger.src:18: W: macro-in-comment %{version} 1 packages and 1 specfiles checked; 0 errors, 8 warnings.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 13 files have unknown license. Detailed output of licensecheck in /home/mrunge/review/1445860-python-fluent- logger/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.6/site- packages, /usr/lib/python3.6 [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -fluent-logger , python3-fluent-logger [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-fluent-logger-0.5.0-1.fc26.noarch.rpm python3-fluent-logger-0.5.0-1.fc26.noarch.rpm python-fluent-logger-0.5.0-1.fc26.src.rpm python2-fluent-logger.noarch: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out python2-fluent-logger.noarch: W: spelling-error %description -l en_US Fluentd -> Fluent, Fluent d python3-fluent-logger.noarch: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out python3-fluent-logger.noarch: W: spelling-error %description -l en_US Fluentd -> Fluent, Fluent d python-fluent-logger.src: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out python-fluent-logger.src: W: spelling-error %description -l en_US Fluentd -> Fluent, Fluent d python-fluent-logger.src:18: W: macro-in-comment %{pypi_name} python-fluent-logger.src:18: W: macro-in-comment %{pypi_name} python-fluent-logger.src:18: W: macro-in-comment %{version} 3 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory python2-fluent-logger.noarch: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out python2-fluent-logger.noarch: W: spelling-error %description -l en_US Fluentd -> Fluent, Fluent d python3-fluent-logger.noarch: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out python3-fluent-logger.noarch: W: spelling-error %description -l en_US Fluentd -> Fluent, Fluent d 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- python2-fluent-logger (rpmlib, GLIBC filtered): python(abi) python-msgpack python3-fluent-logger (rpmlib, GLIBC filtered): python(abi) python3-msgpack Provides -------- python2-fluent-logger: python-fluent-logger python2-fluent-logger python2.7dist(fluent-logger) python2dist(fluent-logger) python3-fluent-logger: python3-fluent-logger python3.6dist(fluent-logger) python3dist(fluent-logger) Source checksums ---------------- https://github.com/fluent/fluent-logger-python/archive/v0.5.0.tar.gz#/fluent-logger-0.5.0.tar.gz : CHECKSUM(SHA256) this package : 85953e7a0d196c9362bf0cab99a058d669a8420a27eab167d2449c28397f4ee2 CHECKSUM(SHA256) upstream package : 85953e7a0d196c9362bf0cab99a058d669a8420a27eab167d2449c28397f4ee2 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1445860 Buildroot used: fedora-rawhide-armhfp Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thanks Matthias for submitting the package review. Below is my couple of comments: * replace python-setuptools to python2-setuptools otherwise it will fail on CBS. * COPYING file contains the LICENSE information what about adding %license macro in each of the subpackage and adding COPYING file there or renaming it to LICENSE. * Since the SOURCE is used from github which contains tests also, please create a -tests subpackage and move the tests there. Rest looks ok to me. Thanks, Chandan Kumar
Please send a rdoinfo rdo gerrit review request for this package: https://www.rdoproject.org/documentation/rdo-packaging/#how-to-add-a-new-package-to-rdo-trunk
Just one modification in my comment: * we can use %license COPYING, we donot need to rename this file. Sorry for the above comment.
rdoinfo review request: https://review.rdoproject.org/r/#/c/6511/
Thank you for the review Chandan, I've addressed your comments in the SPEC: http://www.matthias-runge.de/fedora/python-fluent-logger.spec SRPM: http://www.matthias-runge.de/fedora/python-fluent-logger-0.5.0-2.fc25.src.rpm
chandan, could you please set rdo-review+ ?
This is the Final review: rpmlint warning are related to description which comes from project. This is not an issue. Rest is fine with me. This package is Approved now . Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 13 files have unknown license. Detailed output of licensecheck in /home/chkumar246/killbox/rdo/fedora/reviews/review- python-fluent-logger/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [-]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -fluent-logger , python2-fluent-logger-tests , python3-fluent-logger , python3-fluent-logger-tests [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-fluent-logger-0.5.0-2.fc25.noarch.rpm python2-fluent-logger-tests-0.5.0-2.fc25.noarch.rpm python3-fluent-logger-0.5.0-2.fc25.noarch.rpm python3-fluent-logger-tests-0.5.0-2.fc25.noarch.rpm python-fluent-logger-0.5.0-2.fc25.src.rpm python2-fluent-logger.noarch: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out python2-fluent-logger-tests.noarch: W: spelling-error Summary(en_US) fluentd -> fluent, fluent d python2-fluent-logger-tests.noarch: W: summary-not-capitalized C tests for python-fluentd-logger python2-fluent-logger-tests.noarch: W: spelling-error %description -l en_US fluentd -> fluent, fluent d python2-fluent-logger-tests.noarch: W: no-documentation python2-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/fluent/tests/test_event.py python2-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/fluent/tests/__init__.py python2-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/fluent/tests/test_sender.py python2-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/fluent/tests/mockserver.py python2-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/fluent/tests/test_handler.py python3-fluent-logger.noarch: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out python3-fluent-logger-tests.noarch: W: spelling-error Summary(en_US) fluentd -> fluent, fluent d python3-fluent-logger-tests.noarch: W: summary-not-capitalized C tests for python-fluentd-logger python3-fluent-logger-tests.noarch: W: spelling-error %description -l en_US fluentd -> fluent, fluent d python3-fluent-logger-tests.noarch: W: no-documentation python3-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/fluent/tests/__init__.py python3-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/fluent/tests/test_event.py python3-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/fluent/tests/test_handler.py python3-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/fluent/tests/mockserver.py python3-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/fluent/tests/test_sender.py python-fluent-logger.src: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out python-fluent-logger.src:18: W: macro-in-comment %{pypi_name} python-fluent-logger.src:18: W: macro-in-comment %{pypi_name} python-fluent-logger.src:18: W: macro-in-comment %{version} 5 packages and 0 specfiles checked; 10 errors, 14 warnings. Rpmlint (installed packages) ---------------------------- python2-fluent-logger.noarch: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out python3-fluent-logger-tests.noarch: W: spelling-error Summary(en_US) fluentd -> fluent, fluent d python3-fluent-logger-tests.noarch: W: summary-not-capitalized C tests for python-fluentd-logger python3-fluent-logger-tests.noarch: W: spelling-error %description -l en_US fluentd -> fluent, fluent d python3-fluent-logger-tests.noarch: W: no-documentation python3-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/fluent/tests/test_handler.py python3-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/fluent/tests/mockserver.py python3-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/fluent/tests/test_sender.py python3-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/fluent/tests/test_event.py python3-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/fluent/tests/__init__.py python3-fluent-logger.noarch: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out python2-fluent-logger-tests.noarch: W: spelling-error Summary(en_US) fluentd -> fluent, fluent d python2-fluent-logger-tests.noarch: W: summary-not-capitalized C tests for python-fluentd-logger python2-fluent-logger-tests.noarch: W: spelling-error %description -l en_US fluentd -> fluent, fluent d python2-fluent-logger-tests.noarch: W: no-documentation python2-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/fluent/tests/mockserver.py python2-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/fluent/tests/test_event.py python2-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/fluent/tests/test_sender.py python2-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/fluent/tests/test_handler.py python2-fluent-logger-tests.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/fluent/tests/__init__.py 4 packages and 0 specfiles checked; 10 errors, 10 warnings. Requires -------- python2-fluent-logger (rpmlib, GLIBC filtered): python(abi) python-msgpack python3-fluent-logger-tests (rpmlib, GLIBC filtered): python(abi) python3-fluent-logger python3-fluent-logger (rpmlib, GLIBC filtered): python(abi) python3-msgpack python2-fluent-logger-tests (rpmlib, GLIBC filtered): python(abi) python2-fluent-logger Provides -------- python2-fluent-logger: python-fluent-logger python2-fluent-logger python2.7dist(fluent-logger) python2dist(fluent-logger) python3-fluent-logger-tests: python3-fluent-logger-tests python3-fluent-logger: python3-fluent-logger python3.5dist(fluent-logger) python3dist(fluent-logger) python2-fluent-logger-tests: python2-fluent-logger-tests Source checksums ---------------- https://github.com/fluent/fluent-logger-python/archive/v0.5.0.tar.gz#/fluent-logger-0.5.0.tar.gz : CHECKSUM(SHA256) this package : 85953e7a0d196c9362bf0cab99a058d669a8420a27eab167d2449c28397f4ee2 CHECKSUM(SHA256) upstream package : 85953e7a0d196c9362bf0cab99a058d669a8420a27eab167d2449c28397f4ee2 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -u https://bugzilla.redhat.com/show_bug.cgi?id=1445860 Buildroot used: fedora-25-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
built and tagged in cbs: https://cbs.centos.org/koji/buildinfo?buildID=17129