rhosp-director: Upgrade of compute OSP10-11 - need to clean the message upon finishing upgrading a compute node 


Environment:
openstack-puppet-modules-10.0.0-1.el7ost.noarch
instack-undercloud-6.0.0-6.el7ost.noarch
openstack-tripleo-heat-templates-6.0.0-7.el7ost.noarch
[stack@director ~]$ 


Steps to reproduce:

As part of upgrade try to run:
upgrade-non-controller.sh --upgrade overcloud-compute-0

Result:

Notice: Compiled catalog for overcloud-compute-2.cwdg720xd01.org in environment production in 3.72 seconds
Notice: /Stage[main]/Neutron::Agents::Ml2::Ovs/Neutron_agent_ovs[securitygroup/firewall_driver]/value: value changed 'neutron.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver' to 'iptables_hybrid'
Notice: /Stage[main]/Nova::Compute::Libvirt/Nova_config[libvirt/enabled_perf_events]/ensure: created
Notice: /Stage[main]/Nova::Deps/Anchor[nova::config::end]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Nova::Deps/Anchor[nova::service::begin]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Nova::Compute/Nova::Generic_service[compute]/Service[nova-compute]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Nova::Deps/Anchor[nova::service::end]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Tripleo::Profile::Base::Kernel/Kmod::Load[ip_conntrack_proto_sctp]/Exec[modprobe ip_conntrack_proto_sctp]/returns: executed successfully
Notice: /Stage[main]/Neutron::Deps/Anchor[neutron::config::end]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Neutron::Deps/Anchor[neutron::service::begin]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Neutron::Agents::Ml2::Ovs/Service[neutron-ovs-agent-service]/ensure: ensure changed 'stopped' to 'running'
Notice: /Stage[main]/Neutron::Deps/Anchor[neutron::service::end]: Triggered 'refresh' from 1 events
Notice: Applied catalog in 8.47 seconds
puppet apply exited with exit code 2
+ rc=2
+ echo 'puppet apply exited with exit code 2'
+ set -e
+ '[' 2 -eq 2 -o 2 -eq 0 ']'
+ set +xu
Wed Apr 26 21:31:30 UTC 2017 280d795a-8e43-41a5-826a-394c54b9fb49 tripleo-upgrade overcloud-compute-2 Completed puppet step 5
Wed Apr 26 21:31:30 UTC 2017 280d795a-8e43-41a5-826a-394c54b9fb49 tripleo-upgrade overcloud-compute-2 Running puppet step 6 for Compute
+ local manifest=/root/Compute_puppet_config.pp
+ local role=Compute
+ local step=6
+ local rc=0
+ export FACTER_deploy_config_name=ComputeDeployment_Step6
+ FACTER_deploy_config_name=ComputeDeployment_Step6
+ '[' -e /etc/puppet/hieradata/heat_config_ComputeDeployment_Step6.json ']'
+ echo 'Step6 doesn'\''t exist for Compute'
Step6 doesn't exist for Compute
+ set -e
+ '[' 0 -eq 2 -o 0 -eq 0 ']'
+ set +xu
Wed Apr 26 21:31:30 UTC 2017 280d795a-8e43-41a5-826a-394c54b9fb49 tripleo-upgrade overcloud-compute-2 Completed puppet step 6
Wed Apr 26 21:31:30 UTC 2017 280d795a-8e43-41a5-826a-394c54b9fb49 tripleo-upgrade overcloud-compute-2 TripleO upgrade run completed.


Expected result: more empasize on successfull run as non 0 return from puppet apply may confuse users (despite the fact that exit code 2 means : The run succeeded, and some resources were changed)