Description of problem: Hook script S30samba-start.sh when executed independently throws the following warning: /var/lib/glusterd/hooks/1/start/post/S30samba-start.sh: line 105: [: =: unary operator expected Version-Release number of selected component (if applicable): master How reproducible: Always Steps to Reproduce: 1. Create a simple distribute/replicate volume 2. Start the volume 3. Run the script as follows: # /var/lib/glusterd/hooks/1/start/post/S30samba-start.sh --volname=xcube --gd-workdir=/var/lib/glusterd Actual results: /var/lib/glusterd/hooks/1/start/post/S30samba-start.sh: line 105: [: =: unary operator expected Expected results: No warnings should be seen
REVIEW: https://review.gluster.org/17127 (extras/hooks: Use double quotes while using [..]) posted (#1) for review on master by Anoop C S (anoopcs)
COMMIT: https://review.gluster.org/17127 committed in master by Jeff Darcy (jeff.us) ------ commit ec7a0c7eefacc68532bdc909f05a01eca8b3139d Author: Anoop C S <anoopcs> Date: Thu Apr 27 14:34:08 2017 +0530 extras/hooks: Use double quotes while using [..] This avoids the following warning when first operand is null [: =: unary operator expected Change-Id: I5439d8f60a6d9e30e6ba04c16c3de2096a87c38f BUG: 1446126 Signed-off-by: Anoop C S <anoopcs> Reviewed-on: https://review.gluster.org/17127 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jeff.us>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report. glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html [2] https://www.gluster.org/pipermail/gluster-users/