Bug 1446368 – Silence -Wsign-compare

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1446368 - Silence -Wsign-compare

Summary:	Silence -Wsign-compare

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	pidgin (Show other bugs)
Sub Component:
Version:	7.4
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	rc
Target Release:	---
Assigned To:	Debarshi Ray
QA Contact:	Desktop QE
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-04-27 14:36 EDT by Debarshi Ray
Modified:	2017-08-01 16:20 EDT (History)
CC List:	1 user (show)

See Also:
Fixed In Version:	pidgin-2.10.11-4.el7
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2017-08-01 16:20:06 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2017:1854	normal	SHIPPED_LIVE	Moderate: pidgin security, bug fix, and enhancement update	2017-08-01 14:23:14 EDT

Groups: None (edit)

Description Debarshi Ray 2017-04-27 14:36:51 EDT

Coverity says:

1. pidgin-2.10.11/libpurple/protocols/jabber/auth_cyrus.c:0: scope_hint:
    In function 'remove_current_mech'
2. pidgin-2.10.11/libpurple/protocols/jabber/auth_cyrus.c:190:26: warning:
    comparison between signed and unsigned integer expressions
    [-Wsign-compare]
#    } else if (strlen(pos) > len && *(pos + len) == ' ') {
#                           ^
#   188|   			pos--;
#   189|   			len++;
#   190|-> 		} else if (strlen(pos) > len && *(pos + len) == ' ') {
#   191|   			/* Handle removing space after */
#   192|   			len++;

This is already fixed upstream. Let's just cherry-pick the patch.

Comment 2 Debarshi Ray 2017-04-27 14:51:09 EDT

Here is a scratch build to fix this:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13100299

Comment 3 Debarshi Ray 2017-04-27 14:58:27 EDT

I have built pidgin-2.10.11-4.el7:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13100325

Comment 6 errata-xmlrpc 2017-08-01 16:20:06 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:1854

Note You need to log in before you can comment on or make changes to this bug.