Bug 1446563
| Summary: | [trello mnJMUAey] Better to left align the added saas offering | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Xingxing Xia <xxia> | ||||||||
| Component: | Management Console | Assignee: | Jeff Phillips <jephilli> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | XiaochuanWang <xiaocwan> | ||||||||
| Severity: | low | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 3.6.0 | CC: | aos-bugs, chart, jephilli, jforrest, jokerman, mmccomas, rhamilto, smunilla, spadgett | ||||||||
| Target Milestone: | --- | Flags: | xxia:
needinfo-
|
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2017-07-25 13:56:21 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 1274870 [details]
Added saas offering is center aligned
Hi, this is a design decision. Reassigning to a ux designer. To me the issue is that the offerings take up too much space when they wrap to the second row. I suggest we deal with that as part of https://trello.com/c/h1BT3lyQ The design was altered and the Trello card was reassigned to a dev for implementation. Assigning this to Jeff as he will be implementing the new design. The sass list has been updated to use a Show More / Show Less when there is more than one row. The console will be updated with the latest release of origin-web-catalog, PR https://github.com/openshift/origin-web-console/pull/1578 Please wait till the PR is merged, and then move to MODIFIED not ON_QA PR has been merged Checked in openshift v3.6.95 Now when more than 4 offerings, there is a "Show More" link. Clicking "Show More", the more offerings are left aligned In mobile ipad, the result is same (one difference is one row has no more than 2 offerings as expected) From perspective of left alignment, moving to Verified Created attachment 1285288 [details] mobile-phone Per https://github.com/openshift/openshift-origin-design/pull/34/files#diff-088478d9c15e3488a412d1db527d6c72R38 , it says: The same treatment should be used on mobile when more than one row of SaaS offerings are available (greater than 2). Once more than two offerings exist, the down arrow with appear at the bottom allowing users to expand the section I checked on mobile pad, it has "Show More" when more than 2 offerings. But on mobile phone (such iPhone 6 Plus), no "Show More", all are shown vertically, see attachment "mobile-phone". Should mobile phone have "Show More" or show all? Thanks > I checked on mobile pad, it has "Show More" when more than 2 offerings. But on mobile phone (such iPhone 6 Plus), no "Show More", all are shown vertically, see attachment "mobile-phone". Should mobile phone have "Show More" or show all? Thanks This has been fixed in https://github.com/openshift/origin-web-catalog/pull/261, but note that branch is still a work in progress. Created attachment 1285382 [details]
See more fix for mobile
Thank you. Filed bug 1459391 just for issue track. (In reply to Robb Hamilton from comment #14) > Created attachment 1285382 [details] > See more fix for mobile Your attachment is in mobile pad, already said in comment 12, i.e. "Show More" in mobile pad was already good (In reply to Xingxing Xia from comment #15) > Thank you. Filed bug 1459391 just for issue track. > > (In reply to Robb Hamilton from comment #14) > > Created attachment 1285382 [details] > > See more fix for mobile > > Your attachment is in mobile pad, already said in comment 12, i.e. "Show > More" in mobile pad was already good Oops. Sorry, Xingxing. I will attach the proper screenshots in https://bugzilla.redhat.com/show_bug.cgi?id=1459391. |
Description of problem: The added saas offering is center aligned. Better to left align, which looks better in display. See attachment Version-Release number of selected component (if applicable): openshift v3.6.50 How reproducible: Always Steps to Reproduce: 1. After Service Catalog is deployed, customize the saas offering section by: $ cat saas-offering.js window.OPENSHIFT_CONSTANTS.SAAS_OFFERINGS.push( {id: 5, title: 'XXIA Example App', icon: 'fa fa-cubes', url: 'https://www.redhat.com/en/technologies/management', description: 'this is added by xxia'}) $ vi master-config.yaml ... assetConfig: extensionScripts: - saas-offering.js ... Then restart master service 2. Go to home page, check the added saas offering "XXIA Example App" Actual results: 2. It is center aligned Expected results: 2. Better to left align Additional info: