Description of problem: 5.8 has the Access\Web Console button enabled for windows vms but I don't think cockpit works on windows. Should we add a bug to disable it for Windows VM or is that something that is forthcoming. Assign per instructions: Brian McLaughlin @bmclaughlin 10:40 @jteehan, it looks like you're right regarding Cockpit and Windows. Feel free to open that bug and assign it to me. Version-Release number of selected component (if applicable): 5.8.0.12 How reproducible: Select a running Windows VM with an IP address. Click Access\Web Console Steps to Reproduce: 1. Select a running Windows VM with an IP address 2. Click Access\Web Console 3. Actual results: Browser opens to about:blank and just spins until timeout. Expected results: Additional info: Probably just want to disable it. Opposite of what we do with Collect Running process logic
Added Polarion test case.
https://github.com/ManageIQ/manageiq-ui-classic/pull/1282
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/58666d40c6e57c57e393de8e77c6fe56e8cbdbfd commit 58666d40c6e57c57e393de8e77c6fe56e8cbdbfd Author: Brian McLaughlin <bmclaugh> AuthorDate: Thu May 4 14:22:34 2017 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Tue Jun 6 15:51:44 2017 -0400 Disable Web Console button when platform is Windows https://bugzilla.redhat.com/show_bug.cgi?id=1447100 app/helpers/application_helper/button/cockpit_console.rb | 5 +++++ 1 file changed, 5 insertions(+)
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/3222af276705bd7d89a4e4edc3441f6271027859 commit 3222af276705bd7d89a4e4edc3441f6271027859 Author: Brian McLaughlin <bmclaugh> AuthorDate: Tue May 9 10:53:38 2017 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Tue Jun 6 15:51:44 2017 -0400 Fix broken spec https://bugzilla.redhat.com/show_bug.cgi?id=1447100 app/helpers/application_helper/button/cockpit_console.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/b31810b495c345b153964ddba8022b812582c167 commit b31810b495c345b153964ddba8022b812582c167 Author: Brian McLaughlin <bmclaugh> AuthorDate: Tue Jun 6 22:35:13 2017 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Tue Jun 6 22:35:13 2017 -0400 Refactoring based on feedback https://bugzilla.redhat.com/show_bug.cgi?id=1447100 app/helpers/application_helper/button/cockpit_console.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
This fix causes too many machines to be treated as windows machines. see https://github.com/ManageIQ/manageiq-ui-classic/pull/1282#issuecomment-320729293
https://github.com/ManageIQ/manageiq-ui-classic/pull/1988
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/43a3ca4a7785240d16364daa9f2d5a4730b6a091 commit 43a3ca4a7785240d16364daa9f2d5a4730b6a091 Author: Brian McLaughlin <bmclaugh> AuthorDate: Thu Aug 24 09:59:16 2017 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Tue Aug 29 15:23:48 2017 -0400 Fix logic error when displaying Cockpit button https://bugzilla.redhat.com/show_bug.cgi?id=1447100 app/helpers/application_helper/button/cockpit_console.rb | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
Able to verify this on Version 5.9.0.2.20171010190026_0413a06