Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-he.spec SRPM URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-he-1.1.1-1.fc26.src.rpm Description: he (for “HTML entities”) is a robust HTML entity encoder/decoder written in JavaScript. It supports all standardized named character references as per HTML, handles ambiguous ampersands and other edge cases just like a browser would, has an extensive test suite, and — contrary to many other JavaScript solutions — he handles astral Unicode symbols just fine.
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=19363434
rpmlint throws three errors on this package: nodejs-he.noarch: E: wrong-script-interpreter /usr/bin/he /usr/bin/env node nodejs-he.noarch: E: wrong-script-interpreter /usr/lib/node_modules/he/scripts/scrape-spec.js /usr/bin/env phantomjs nodejs-he.noarch: E: non-executable-script /usr/lib/node_modules/he/scripts/scrape-spec.js 644 /usr/bin/env phantomjs For the first and second, simply add the following lines to your %prep section: sed -i '1s/env //' bin/he sed -i '1s/env //' scripts/scrape-spec.js For the third, you'll want use chmod to make the script executable.
Thanks for the fix. Here is the updated package Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-he.spec SRPM URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-he-1.1.1-2.fc26.src.rpm but I found that this package needs runtime dependency of phantomjs. Need to check on it if it needs to be packaged in Fedora.
I decided to remove that single file scripts/scrape-spec.js which needs phantomjs binary. Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-he.spec SRPM URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-he-1.1.1-3.fc26.src.rpm
Package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 35 files have unknown license. Detailed output of licensecheck in /home/jsmith/Documents/Personal/Reviews/1447224-nodejs- he/licensecheck.txt [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.1 starting (python version = 3.6.1)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.1 INFO: Mock Version: 1.4.1 Finish: chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.1 INFO: Mock Version: 1.4.1 Finish: chroot init INFO: installing package(s): /home/jsmith/Documents/Personal/Reviews/1447224-nodejs-he/results/nodejs-he-1.1.1-3.fc27.noarch.rpm Rpmlint ------- Checking: nodejs-he-1.1.1-3.fc27.noarch.rpm nodejs-he-1.1.1-3.fc27.src.rpm nodejs-he.noarch: W: only-non-binary-in-usr-lib nodejs-he.noarch: W: no-manual-page-for-binary he 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- nodejs-he (rpmlib, GLIBC filtered): /usr/bin/node nodejs(engine) Provides -------- nodejs-he: nodejs-he npm(he) Source checksums ---------------- https://github.com/mathiasbynens/he/archive/v1.1.1.tar.gz : CHECKSUM(SHA256) this package : bfa2b8334647e0693d2fa237a9c2ffd2af3bd980d6651087969dc1fe0e83daee CHECKSUM(SHA256) upstream package : bfa2b8334647e0693d2fa237a9c2ffd2af3bd980d6651087969dc1fe0e83daee Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1447224 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-he