Bug 1447826 - potential endless loop in function glusterfs_graph_validate_options
Summary: potential endless loop in function glusterfs_graph_validate_options
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zhou Zhengping
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-04 01:08 UTC by Zhou Zhengping
Modified: 2017-09-05 17:28 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.12.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-05 17:28:29 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Zhou Zhengping 2017-05-04 01:08:25 UTC
Description of problem:


        while (trav) {
                if (list_empty (&trav->volume_options))
                        continue; //if get here, will going to be endless loop

                ret = xlator_options_validate (trav, trav->options, &errstr);
                if (ret) {
                        gf_msg (trav->name, GF_LOG_ERROR, 0,
                                LG_MSG_VALIDATION_FAILED, "validation failed: "
                                "%s", errstr);
                        return ret; 
                }    
                trav = trav->next;
        }  

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-05-04 01:09:05 UTC
REVIEW: https://review.gluster.org/17171 (libglusterfs/graph: fix potential endless loop in options validate work) posted (#1) for review on master by Zhou Zhengping (johnzzpcrystal)

Comment 2 Worker Ant 2017-05-04 01:10:51 UTC
REVIEW: https://review.gluster.org/17171 (libglusterfs/graph: fix potential endless loop in options validate work) posted (#2) for review on master by Zhou Zhengping (johnzzpcrystal)

Comment 3 Worker Ant 2017-05-09 12:57:08 UTC
COMMIT: https://review.gluster.org/17171 committed in master by Niels de Vos (ndevos) 
------
commit 0f552c509f5a12bda6b7b160a82a9322986655c6
Author: Zhou Zhengping <johnzzpcrystal>
Date:   Thu May 4 09:01:37 2017 +0800

    libglusterfs/graph: fix potential endless loop in options validate work
    
    Change-Id: Icb71ded6051afe44e07480e0499d2a39f05fac71
    BUG: 1447826
    Signed-off-by: Zhou Zhengping <johnzzpcrystal>
    Reviewed-on: https://review.gluster.org/17171
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

Comment 4 Shyamsundar 2017-09-05 17:28:29 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.