Bug 1447826
| Summary: | potential endless loop in function glusterfs_graph_validate_options | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Zhou Zhengping <johnzzpcrystal> |
| Component: | core | Assignee: | Zhou Zhengping <johnzzpcrystal> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | mainline | CC: | anraj, bugs |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.12.0 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-09-05 17:28:29 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
REVIEW: https://review.gluster.org/17171 (libglusterfs/graph: fix potential endless loop in options validate work) posted (#1) for review on master by Zhou Zhengping (johnzzpcrystal) REVIEW: https://review.gluster.org/17171 (libglusterfs/graph: fix potential endless loop in options validate work) posted (#2) for review on master by Zhou Zhengping (johnzzpcrystal) COMMIT: https://review.gluster.org/17171 committed in master by Niels de Vos (ndevos) ------ commit 0f552c509f5a12bda6b7b160a82a9322986655c6 Author: Zhou Zhengping <johnzzpcrystal> Date: Thu May 4 09:01:37 2017 +0800 libglusterfs/graph: fix potential endless loop in options validate work Change-Id: Icb71ded6051afe44e07480e0499d2a39f05fac71 BUG: 1447826 Signed-off-by: Zhou Zhengping <johnzzpcrystal> Reviewed-on: https://review.gluster.org/17171 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Amar Tumballi <amarts> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Niels de Vos <ndevos> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report. glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html [2] https://www.gluster.org/pipermail/gluster-users/ |
Description of problem: while (trav) { if (list_empty (&trav->volume_options)) continue; //if get here, will going to be endless loop ret = xlator_options_validate (trav, trav->options, &errstr); if (ret) { gf_msg (trav->name, GF_LOG_ERROR, 0, LG_MSG_VALIDATION_FAILED, "validation failed: " "%s", errstr); return ret; } trav = trav->next; } Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: