Bug 1447875 - Create a conf.d for ovirt-provider-ovn configuration
Summary: Create a conf.d for ovirt-provider-ovn configuration
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-provider-ovn
Classification: oVirt
Component: provider
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ovirt-4.2.0
: ---
Assignee: Marcin Mirecki
QA Contact: Mor
URL:
Whiteboard:
Depends On:
Blocks: 1565965
TreeView+ depends on / blocked
 
Reported: 2017-05-04 06:24 UTC by Marcin Mirecki
Modified: 2018-04-16 02:36 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:17:56 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 77778 0 'None' 'MERGED' 'packaging: save the ovirt-engine provider id' 2019-11-27 14:25:40 UTC
oVirt gerrit 77829 0 'None' 'MERGED' 'Allow to extend configuration with additional file in conf.d' 2019-11-27 14:25:40 UTC

Description Marcin Mirecki 2017-05-04 06:24:21 UTC
Requested in:

https://gerrit.ovirt.org/#/c/74888/30/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py@321

I'd rather not edit in-place if possible. Two other options:

1. If the user is not expected to edit this manually, read it from a template, and have a comment saying the file should not be edited manually

2. Better make the provider read  all files from some directory, e.g. /etc/ovirt-provider-ovn/ovirt-provider-ovn.conf.d/*.conf, so that you can overwrite your file there, and users can add their own file, similarly to e.g. the engine

Comment 1 Mor 2017-06-19 07:14:37 UTC
Verified on version:
4.2.0-0.0.master.20170612192318.gitf773263.el7.centos

I have created 3 files under /etc/ovirt-provider-ovn/conf.d:
01-test.conf, 02-test.conf and a-test.conf, and altered the default 'http-enabled' and 'ssl-key-file', 'ssl-cert-file', 'ssl-cacert-file' settings under SSL section, taking into consideration the order of config files (01 then 02 then a). It overwrites the default values with the value set on the last file in order.

Comment 2 Sandro Bonazzola 2017-12-20 11:17:56 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.