Bug 1447965 - Undertow metrics processing-time, processing-time-per-minute and max-processing time do not scale units in charts
Summary: Undertow metrics processing-time, processing-time-per-minute and max-processi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: UI, Usability
Version: JON 3.3.8
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: CR02
: JON 3.3.9
Assignee: Ruben Vargas Palma
QA Contact: Jeeva Kandasamy
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-04 10:34 UTC by Filip Brychta
Modified: 2017-10-02 17:22 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-10-02 17:22:36 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screen shot (163.26 KB, image/png)
2017-05-04 10:34 UTC, Filip Brychta
no flags Details
failed QA (206.49 KB, image/png)
2017-09-21 16:36 UTC, Jeeva Kandasamy
no flags Details
verified qa (217.25 KB, image/png)
2017-09-25 11:53 UTC, Jeeva Kandasamy
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1420681 0 high CLOSED Undertow metrics processing-time, processing-time-per-minute and max-processing time do not show "unit" in the graph 2021-02-22 00:41:40 UTC
Red Hat Product Errata RHEA-2017:2846 0 normal SHIPPED_LIVE Red Hat JBoss Operations Network 3.3.9 bug fix update 2017-10-02 21:21:28 UTC

Internal Links: 1420681

Description Filip Brychta 2017-05-04 10:34:36 UTC
Created attachment 1276229 [details]
screen shot

Description of problem:
Undertow metrics processing-time, processing-time-per-minute and max-processing time are shown in ns in charts so it is huge number when actual time is in seconds.

Version-Release number of selected component (if applicable):
JON 3.3.8 + eap plugin pack 05

How reproducible:
Always

Steps to Reproduce:
1. Install JBoss ON;
2. Start and import EAP 7 server into JBoss ON inventory;
3. Enable statistics on the EAP 7 server by executing:

    /subsystem=undertow:write-attribute(name="statistics-enabled",value=true)

4. Enable processing-time collection by setting "record-request-start-time" to true:

    /subsystem=undertow/server=default-server/http-listener=default:write-attribute(name="record-request-start-time",value=true)

5. Create requests/load on this http-listener


Actual results:
Huge numbers are shown in the "Processing Time per Minute" graph - for instance 49990188766.4934 

Expected results:
The value 49990188766.4934 - is shown as seconds and the graph shows correct unit.

Additional info:
See attached screenshot
See bz 1420681 for changes done in plugin.

Comment 1 Michael Burman 2017-05-05 11:45:39 UTC
Isn't this duplicate of BZ 1240681 and not related? Without units, there can't be any scaling.

Comment 2 Filip Brychta 2017-05-05 13:17:32 UTC
See comment 10 from bz 1420681. Scaling (showing ns,ms,s depending on value) should be fixed in core. Bz 1420681 fixed missing units but charts still show ns even for huge numbers.

Comment 7 Simeon Pinder 2017-09-19 11:33:23 UTC
Moving to ON_QA.

JON 3.3.9 CR01 artifacts are available for test from here:
http://download.eng.bos.redhat.com/brewroot/packages/org.jboss.on-jboss-on-parent/3.3.0.GA/135/maven/org/jboss/on/jon-server-patch/3.3.0.GA/jon-server-patch-3.3.0.GA.zip
 *Note: jon-server-patch-3.3.0.GA.zip maps to CR01 build of
 jon-server-3.3.0.GA-update-09.zip.

Comment 8 Jeeva Kandasamy 2017-09-21 16:36:26 UTC
Created attachment 1329072 [details]
failed QA

The value shown on the table is Seconds(s) but on the graph showing as milliseconds(ms). The screenshot is attached.


Version info:
-------------

OS: Fedora 26
Browser: Firefox 55.0.3 (64-bit)

JBoss Operations Network	
Version: 3.3.0.GA Update 09
Build Number: 44ba698:204e925
GWT Version: 2.5.0
SmartGWT Version: 3.0p

Comment 9 Michael Burman 2017-09-21 20:31:25 UTC
I don't think the seconds is the key issue here. Our graph scales to milliseconds / seconds / nanoseconds automatically depending on the value.

If the user has small values here (say, processing time is 1.3456ms on average), then showing it as 0.0013456 seconds looks just silly. 

To me the problem looks to be that "graph" uses different scaling than "table" and that's the thing that should be fixed.

Comment 10 Jeeva Kandasamy 2017-09-22 01:42:54 UTC
(In reply to Michael Burman from comment #9)
> I don't think the seconds is the key issue here. Our graph scales to
> milliseconds / seconds / nanoseconds automatically depending on the value.
>
> If the user has small values here (say, processing time is 1.3456ms on
> average), then showing it as 0.0013456 seconds looks just silly. 
> 
> To me the problem looks to be that "graph" uses different scaling than
> "table" and that's the thing that should be fixed.

Yes, My concern is same here. "table" and "graph" should not use different scaling.

Comment 13 Jeeva Kandasamy 2017-09-25 11:53:09 UTC
Created attachment 1330497 [details]
verified qa

works as expected.

Version info:
-------------

OS: Fedora 26
Browser: Firefox 55.0.3 (64-bit)

JBoss Operations Network	
Version: 3.3.0.GA Update 09
Build Number: fcb34f1:80f74f5
GWT Version: 2.5.0
SmartGWT Version: 3.0p

Comment 14 errata-xmlrpc 2017-10-02 17:22:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:2846


Note You need to log in before you can comment on or make changes to this bug.