Bug 1448368 – openshift_docker_use_system_container and openshift_docker_systemcontainer_image_registry_override didn't work

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1448368 - openshift_docker_use_system_container and openshift_docker_systemcontainer_image_registry_override didn't work

Summary:	openshift_docker_use_system_container and openshift_docker_systemcontainer_im...

Status:	CLOSED ERRATA

Aliases:	None

Product:	OpenShift Container Platform
Classification:	Red Hat
Component:	Installer (Show other bugs)
Sub Component:
Version:	3.6.0
Hardware:	Unspecified Unspecified

Priority	medium Severity medium
Target Milestone:	---
Target Release:	---
Assigned To:	Steve Milner
QA Contact:	Johnny Liu
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-05-05 05:53 EDT by Gan Huang
Modified:	2017-08-16 15 EDT (History)
CC List:	5 users (show)

See Also:
Fixed In Version:
Doc Type:	No Doc Update
Doc Text:	undefined
Story Points:	---
Clone Of:
Environment:
Last Closed:	2017-08-10 01:21:25 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHEA-2017:1716	normal	SHIPPED_LIVE	Red Hat OpenShift Container Platform 3.6 RPM Release Advisory	2017-08-10 05:02:50 EDT

Groups: None (edit)

Description Gan Huang 2017-05-05 05:53:25 EDT

Description of problem:
The parameters didn't work as the setting in inventory hosts file:

<--snip-->
openshift_docker_use_system_container=True
openshift_docker_systemcontainer_image_registry_override=test.registry.xxx.com/rhel7/
<--snip-->

Version-Release number of selected component (if applicable):
openshift-ansible-3.6.53-1.git.0.03f33da.el7.noarch

How reproducible:
always

Steps to Reproduce:

1.#cat inventory_hosts
openshift_docker_use_system_container=True
openshift_docker_systemcontainer_image_registry_override=test.registry.xxx.com/rhel7/

2.Add debug tasks in roles/docker/tasks/main.yml

- include: udev_workaround.yml
  when: docker_udev_workaround | default(False) | bool

- debug:
    var=openshift.docker.use_system_container

- debug:
    var=openshift.docker.systemcontainer_image_registry_override

- debug:
    var=openshift.docker.service_name

3. Run BYO playbook


Actual results:

Installer didn't install and configure docker system container.
<--snip-->
TASK [docker : debug] **********************************************************
ok: [host-8-175-193.host.centralci.eng.rdu2.redhat.com] => {
    "openshift.docker.use_system_container": "VARIABLE IS NOT DEFINED!"
}
ok: [host-8-175-186.host.centralci.eng.rdu2.redhat.com] => {
    "openshift.docker.use_system_container": "VARIABLE IS NOT DEFINED!"
}

TASK [docker : debug] **********************************************************
ok: [host-8-175-193.host.centralci.eng.rdu2.redhat.com] => {
    "openshift.docker.systemcontainer_image_registry_override": "VARIABLE IS NOT DEFINED!"
}
ok: [host-8-175-186.host.centralci.eng.rdu2.redhat.com] => {
    "openshift.docker.systemcontainer_image_registry_override": "VARIABLE IS NOT DEFINED!"
}

TASK [docker : debug] **********************************************************
ok: [host-8-175-193.host.centralci.eng.rdu2.redhat.com] => {
    "openshift.docker.service_name": "docker"
}
ok: [host-8-175-186.host.centralci.eng.rdu2.redhat.com] => {
    "openshift.docker.service_name": "docker"



Expected results:
Installer should install and configure docker system container.

Additional info:

Comment 1 Gan Huang 2017-05-05 06:46:58 EDT

Proposed PR which should include this fix: https://github.com/openshift/openshift-ansible/pull/4103

Comment 2 Steve Milner 2017-05-05 10:13:48 EDT

Thanks for the report. I'm looking into why the value is not propagating now.

Comment 3 Steve Milner 2017-05-05 11:23:11 EDT

https://github.com/openshift/openshift-ansible/pull/4103 looks like it makes sense to me. Putting it through CI and if all goes well I'll merge it. Thanks Gan!

Comment 4 Steve Milner 2017-05-05 13:40:47 EDT

Merged the PR.

Comment 6 Gan Huang 2017-05-10 04:26:00 EDT

Fixed in openshift-ansible-3.6.65-1.git.0.512ef0f.el7.noarch.rpm

openshift_docker_use_system_container and openshift_docker_systemcontainer_image_registry_override work as expected.

Comment 8 errata-xmlrpc 2017-08-10 01:21:25 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1716

Note You need to log in before you can comment on or make changes to this bug.