Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1448368

Summary: openshift_docker_use_system_container and openshift_docker_systemcontainer_image_registry_override didn't work
Product: OpenShift Container Platform Reporter: Gan Huang <ghuang>
Component: InstallerAssignee: Steve Milner <smilner>
Status: CLOSED ERRATA QA Contact: Johnny Liu <jialiu>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.6.0CC: aos-bugs, jokerman, mmccomas, sdodson, smilner
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-10 05:21:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Gan Huang 2017-05-05 09:53:25 UTC
Description of problem:
The parameters didn't work as the setting in inventory hosts file:

<--snip-->
openshift_docker_use_system_container=True
openshift_docker_systemcontainer_image_registry_override=test.registry.xxx.com/rhel7/
<--snip-->

Version-Release number of selected component (if applicable):
openshift-ansible-3.6.53-1.git.0.03f33da.el7.noarch

How reproducible:
always

Steps to Reproduce:

1.#cat inventory_hosts
openshift_docker_use_system_container=True
openshift_docker_systemcontainer_image_registry_override=test.registry.xxx.com/rhel7/

2.Add debug tasks in roles/docker/tasks/main.yml

- include: udev_workaround.yml
  when: docker_udev_workaround | default(False) | bool

- debug:
    var=openshift.docker.use_system_container

- debug:
    var=openshift.docker.systemcontainer_image_registry_override

- debug:
    var=openshift.docker.service_name

3. Run BYO playbook


Actual results:

Installer didn't install and configure docker system container.
<--snip-->
TASK [docker : debug] **********************************************************
ok: [host-8-175-193.host.centralci.eng.rdu2.redhat.com] => {
    "openshift.docker.use_system_container": "VARIABLE IS NOT DEFINED!"
}
ok: [host-8-175-186.host.centralci.eng.rdu2.redhat.com] => {
    "openshift.docker.use_system_container": "VARIABLE IS NOT DEFINED!"
}

TASK [docker : debug] **********************************************************
ok: [host-8-175-193.host.centralci.eng.rdu2.redhat.com] => {
    "openshift.docker.systemcontainer_image_registry_override": "VARIABLE IS NOT DEFINED!"
}
ok: [host-8-175-186.host.centralci.eng.rdu2.redhat.com] => {
    "openshift.docker.systemcontainer_image_registry_override": "VARIABLE IS NOT DEFINED!"
}

TASK [docker : debug] **********************************************************
ok: [host-8-175-193.host.centralci.eng.rdu2.redhat.com] => {
    "openshift.docker.service_name": "docker"
}
ok: [host-8-175-186.host.centralci.eng.rdu2.redhat.com] => {
    "openshift.docker.service_name": "docker"



Expected results:
Installer should install and configure docker system container.

Additional info:

Comment 1 Gan Huang 2017-05-05 10:46:58 UTC
Proposed PR which should include this fix: https://github.com/openshift/openshift-ansible/pull/4103

Comment 2 Steve Milner 2017-05-05 14:13:48 UTC
Thanks for the report. I'm looking into why the value is not propagating now.

Comment 3 Steve Milner 2017-05-05 15:23:11 UTC
https://github.com/openshift/openshift-ansible/pull/4103 looks like it makes sense to me. Putting it through CI and if all goes well I'll merge it. Thanks Gan!

Comment 4 Steve Milner 2017-05-05 17:40:47 UTC
Merged the PR.

Comment 6 Gan Huang 2017-05-10 08:26:00 UTC
Fixed in openshift-ansible-3.6.65-1.git.0.512ef0f.el7.noarch.rpm

openshift_docker_use_system_container and openshift_docker_systemcontainer_image_registry_override work as expected.

Comment 8 errata-xmlrpc 2017-08-10 05:21:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1716