Bug 1448682 - Change file permissions on OVN configuration file
Summary: Change file permissions on OVN configuration file
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-provider-ovn
Classification: oVirt
Component: provider
Version: 1.0.4
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.2.0
: ---
Assignee: Marcin Mirecki
QA Contact: Mor
URL:
Whiteboard:
: 1434861 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-07 06:14 UTC by Mor
Modified: 2017-12-20 11:22 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2017-12-20 11:22:07 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 77124 0 ovirt-4.1 ABANDONED Set file permission to 544 for installed files. 2017-05-23 14:25:32 UTC
oVirt gerrit 77197 0 master MERGED Set file permission to 544 for installed files. 2017-05-23 17:27:48 UTC

Description Mor 2017-05-07 06:14:48 UTC
Description of problem:
Since we are storing SSO secret in ovirt-provider-ovn.conf which is used for provider authentication by role, we should change the file permissions from 755 to 750 to restrict everyone from accessing the content.

Version-Release number of selected component (if applicable):
virt-provider-ovn-1.1-2.20170505083409.git1cc74cb.el7.centos.noarch

How reproducible:
100%

Steps to Reproduce:
1. Install ovirt-provider-ovn package.

Actual results:
ls -al /etc/ovirt-provider-ovn/ovirt-provider-ovn.conf
-rwxr-xr-x. 1 root root 923 May  5 11:34 /etc/ovirt-provider-ovn/ovirt-provider-ovn.conf


Expected results:
Should be -rwxr-x---

Additional info:

Comment 1 Dan Kenigsberg 2017-05-07 17:38:10 UTC
P.S config files should not be marked as executable.

Comment 2 Marcin Mirecki 2017-05-23 13:45:35 UTC
Fixed for all files collectively in one patch.

Comment 3 Marcin Mirecki 2017-05-23 14:21:00 UTC
*** Bug 1434861 has been marked as a duplicate of this bug. ***

Comment 4 Mor 2017-05-29 14:58:24 UTC
Verified on:
ovirt-provider-ovn.noarch 0:1.1-2.20170525114308.git975a64f.el7.centos

# ls -al /etc/ovirt-provider-ovn/ovirt-provider-ovn.conf
-rw-r--r--. 1 root root 1019 May 25 14:43 /etc/ovirt-provider-ovn/ovirt-provider-ovn.conf

Comment 5 Mor 2017-05-29 14:58:33 UTC
Verified on:
ovirt-provider-ovn.noarch 0:1.1-2.20170525114308.git975a64f.el7.centos

# ls -al /etc/ovirt-provider-ovn/ovirt-provider-ovn.conf
-rw-r--r--. 1 root root 1019 May 25 14:43 /etc/ovirt-provider-ovn/ovirt-provider-ovn.conf

Comment 6 Sandro Bonazzola 2017-12-20 11:22:07 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.