Spec URL: http://scientific.zcu.cz/fedora/rubygem-json-schema-2.8.0-1/rubygem-json-schema.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-json-schema-2.8.0-1/rubygem-json-schema-2.8.0-1.fc26.src.rpm Description: Ruby JSON Schema Validator. Fedora Account System Username: valtri COPR builds: https://copr.fedorainfracloud.org/coprs/valtri/ruby/build/548664/
Taking. I would appreciate it if you would review my review request (bug 1448298)
One recommendation * I usually recommend to place "README.md" to main package, as it says "README", however this is up to your decision. * license okay * source matches the upstream * spec file clean * koji build okay (F-27, F-26) * rpmlint clean * installation okay * basic functionality (taken from README.md) works. $ ruby -e 'require "json-schema" ; schema = {"type"=>"object", "required"=>["a"], "properties"=>{"a"=>{"type"=>"integer"}}} ; p JSON::Validator.validate(schema, { "a" => 5 }) ; p JSON::Validator.validate(schema, { "a" => 4.3 })' true false ===================================================== This package (rubygem-json-schema) is APPROVED by mtasaka =====================================================
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-json-schema
rubygem-json-schema-2.8.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e08c3c0474
rubygem-json-schema-2.8.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2290ea410a
rubygem-json-schema-2.8.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e08c3c0474
rubygem-json-schema-2.8.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2290ea410a
rubygem-json-schema-2.8.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-json-schema-2.8.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.