Bug 1448710
| Summary: | [RFE] Add 'Default SAN discard after delete' option to engine-setup | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Elad <ebenahar> |
| Component: | RFEs | Assignee: | Sandro Bonazzola <sbonazzo> |
| Status: | CLOSED WONTFIX | QA Contact: | Gil Klein <gklein> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.2.0 | CC: | amureini, bugs, ebenahar, ishaby, sbonazzo, ylavi |
| Target Milestone: | --- | Keywords: | FutureFeature |
| Target Release: | --- | Flags: | sbonazzo:
ovirt-4.2-
|
| Hardware: | x86_64 | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-05-29 06:33:40 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
No, the default should be true without asking the user. Isn't it the case today, for a storage that supports discard? (In reply to Yaniv Kaul from comment #1) > No, the default should be true without asking the user. Isn't it the case > today, for a storage that supports discard? Currently, the default is false no matter whether the storage supports discard or not. The verification against the storage if it supports or not is done only upon changing the flag to true. Elad, I see in engine-setup we currently have: Default SAN wipe after delete, defaulting to No. How the 2 options should work together? What's the VDC option to be set? (In reply to Sandro Bonazzola from comment #3) > Elad, I see in engine-setup we currently have: > Default SAN wipe after delete, defaulting to No. > > How the 2 options should work together? > > What's the VDC option to be set? wipe_after_delete and discard_after_delete are 2 different flags for storage domain, they are not related. Since we can't tell whether the storage supports discard or not before creating a SAN domain, we'll have to set the new 'Default SAN wipe after delete' to false in engine-setup to false * 'Default SAN discard after delete' What's the VDC option to be set? AFAIK, it's CreateStorageDomainVDSCommand but I'm not 100% sure. Idan? (In reply to Elad from comment #7) > AFAIK, it's CreateStorageDomainVDSCommand but I'm not 100% sure. Idan? * Elad, currently there is no VDC option to set since this BZ is a new request. We should add one if we decide to go for it. * Yaniv, we used a default of false in "Discard After Delete" and "Enable Discard" since we didn't want to change the behavior of existing domains and vm disks. It can be easily done, however, if we want to. Allon, your two cents about these two ideas? (In reply to Idan Shaby from comment #8) > Allon, your two cents about these two ideas? It's a small engineering effort no matter what way we go. I don't have any strong feeling about this, whatever PM decides is fine with me. New domain should default to true on Discard and Discard After Delete. In upgrade we can not change to enable this for existing domains. I don't think we should add more questions to the setup. there are already too many questions as it is. (In reply to Yaniv Dary from comment #10) > New domain should default to true on Discard and Discard After Delete. > In upgrade we can not change to enable this for existing domains. > > I don't think we should add more questions to the setup. > there are already too many questions as it is. Closing won't fix. (In reply to Sandro Bonazzola from comment #11) > (In reply to Yaniv Dary from comment #10) > > New domain should default to true on Discard and Discard After Delete. > > In upgrade we can not change to enable this for existing domains. > > Did we open a ticket to preform this? |
Description of problem: Need to add an option to change the default value (true or false) for discard after delete for SAN storage in engine-setup. Something like the following: Default SAN discard after delete (Yes, No) [No]: