Bug 1448798 - [TEXT] - Improve the error message when host-deploy reports an error
Summary: [TEXT] - Improve the error message when host-deploy reports an error
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.1.2.1
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ovirt-4.2.0
: 4.2.0
Assignee: Miroslava Voglova
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-08 08:07 UTC by Michael Burman
Modified: 2017-12-20 11:02 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:02:42 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)
engine logs (873.70 KB, application/x-gzip)
2017-05-08 08:07 UTC, Michael Burman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 79022 0 master MERGED engine: VDS_INSTALL_IN_PROGRESS_ERROR text change 2017-07-13 08:21:40 UTC

Description Michael Burman 2017-05-08 08:07:03 UTC
Created attachment 1276997 [details]
engine logs

Description of problem:
[TEXT] - Improve the error message when adding 3.6 host to rhv-m 4.1.

As BZ 1443508 is now fixed and there is no fatal failure any more when adding 3.6 host to rhv-m 4.1(cause of the collectd and fluentd packages), engine displaying confusing errors messages in the event log ui and saying that installation has failed, although succeeded.   

Version-Release number of selected component (if applicable):
4.1.2.1-0.1.el7

How reproducible:
100

Steps to Reproduce:
1. Add 3.6 host to rhv-m 4.1

Actual results:
Confusing error message about installation failure. But installation now succeeded with the fix of BZ 1443508

Expected results:
Show proper message for such scenario.

Additional info:
See BZ 1443508

Comment 1 Michael Burman 2017-05-08 08:15:04 UTC
2017-05-08 09:32:00,811+03 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (VdsDeploy) [327b5669] EVENT_ID: VDS_INSTALL_IN_PROGRESS(509), Correlation ID: 327b5669, Call Stack: null, Cu
stom Event ID: -1, Message: Installing Host orchid-vds2.qa.lab.tlv.redhat.com. Stage: Package installation.
2017-05-08 09:32:01,456+03 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (VdsDeploy) [327b5669] EVENT_ID: VDS_INSTALL_IN_PROGRESS_ERROR(511), Correlation ID: 327b5669, Call Stack: nu
ll, Custom Event ID: -1, Message: Failed to install Host orchid-vds2.qa.lab.tlv.redhat.com. Yum Cannot queue package collectd: Package collectd cannot be found.
2017-05-08 09:32:01,499+03 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (VdsDeploy) [327b5669] EVENT_ID: VDS_INSTALL_IN_PROGRESS_WARNING(510), Correlation ID: 327b5669, Call Stack: 
null, Custom Event ID: -1, Message: Host orchid-vds2.qa.lab.tlv.redhat.com installation in progress . Failed to install collectd packages: Package collectd cannot be found.
2017-05-08 09:32:01,527+03 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (VdsDeploy) [327b5669] EVENT_ID: VDS_INSTALL_IN_PROGRESS_ERROR(511), Correlation ID: 327b5669, Call Stack: nu
ll, Custom Event ID: -1, Message: Failed to install Host orchid-vds2.qa.lab.tlv.redhat.com. Yum Cannot queue package fluentd: Package fluentd cannot be found.
2017-05-08 09:32:01,545+03 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (VdsDeploy) [327b5669] EVENT_ID: VDS_INSTALL_IN_PROGRESS_WARNING(510), Correlation ID: 327b5669, Call Stack: 
null, Custom Event ID: -1, Message: Host orchid-vds2.qa.lab.tlv.redhat.com installation in progress . Failed to install fluentd packages: Package fluentd cannot be found.
2017-05-08 09:32:03,308+03 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (VdsDeploy) [327b5669] EVENT_ID: VDS_INSTALL_IN_PROGRESS(509), Correlation ID: 327b5669, Call Stack: null, Cu
stom Event ID: -1, Message: Installing Host orchid-vds2.qa.lab.tlv.redhat.com. Yum Status: Downloading Packages.

Comment 2 Yedidyah Bar David 2017-05-08 09:16:22 UTC
Changing summary and clarifying:

This bug is about the error message VDS_INSTALL_IN_PROGRESS_ERROR. I don't know well the engine side of host-deploy, but it seems to be emitted to the user every time host-deploy reports an error. The text is currently "Failed to install Host", which is wrong and misleading - as this message is sent in the middle of host-deploy, when the engine still can't know if the installation failed or not.

The flow described in comment 0 is just an example. Now searched the source code of host-deploy and it seems like we have a few more similar flows (although I didn't verify any of them):
- trying to deploy with hosted-engine on non-x86_64 (e.g. ppc)
- failing to set hosted-engine local maintenance to "none"

So please either make sure that VDS_INSTALL_IN_PROGRESS_ERROR is indeed always used only for in-progress reporting, and change its text accordingly, or change the code to use different constants and texts for in-progress errors vs real failures.

Comment 3 Michael Burman 2017-08-30 08:08:36 UTC
Verified on - 4.2.0-0.0.master.20170828065003.git0619c76.el7.centos

Tested only the scenario which was reported in comment#0.

"An error has occurred during installation of Host orchid-vds2.qa.lab.tlv.redhat.com: Yum Cannot queue package vdsm-client: Package vdsm-client cannot be found."

2017-08-30 10:04:03,374+03 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (VdsDeploy) [6bb71664] EVENT_ID: VDS_INSTALL_IN_PROGRESS_ERROR(511), An error has occurred during installatio
n of Host orchid-vds2.qa.lab.tlv.redhat.com: Yum Cannot queue package vdsm-client: Package vdsm-client cannot be found.

Comment 4 Sandro Bonazzola 2017-12-20 11:02:42 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.