Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1448800

Summary:	Docker service should not be started while starting atomic-openshift-node service if docker is installed as system container
Product:	OpenShift Container Platform	Reporter:	Gan Huang <ghuang>
Component:	Installer	Assignee:	Steve Milner <smilner>
Status:	CLOSED ERRATA	QA Contact:	Gan Huang <ghuang>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.6.0	CC:	aos-bugs, jokerman, mmccomas, myllynen
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-10 05:23:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1448372
Bug Blocks:

Description Gan Huang 2017-05-08 08:11:11 UTC

Description of problem:
Docker service would be started while starting atomic-openshift-node service due to Docker service is a dependence of atomic-openshift-node service.

Version-Release number of selected component (if applicable):
openshift-ansible-3.6.53-1.git.0.03f33da.el7.noarch

How reproducible:
always

Steps to Reproduce:
1. Trigger the installation using docker system container

#cat inventory_hosts
<--snip-->
openshift_docker_use_system_container=True
openshift_docker_systemcontainer_image_registry_override=test.registry.xxx.com/rhel7/

2. Restart atomic-openshift-node service after installation


Actual results:
Docker service would be started while restarting atomic-openshift-node service

This is because Docker service is still a dependence of atomic-openshift-node service:

# cat /usr/lib/systemd/system/atomic-openshift-node.service
[Unit]
Description=Atomic OpenShift Node
After=docker.service
After=openvswitch.service
Wants=docker.service
Documentation=https://github.com/openshift/origin

<--snip-->

Expected results:
Docker service shouldn't be started if using docker system container as docker is wrapped as `container-engine` service.

Additional info:

Comment 1 Steve Milner 2017-05-09 14:46:19 UTC

PR: https://github.com/openshift/openshift-ansible/pull/4131

Comment 2 Steve Milner 2017-05-11 01:06:15 UTC

Merged.

Comment 4 Gan Huang 2017-05-15 06:25:48 UTC

Verified with openshift-ansible-3.6.68-1.git.0.9cbe2b7.el7.noarch.rpm

/usr/lib/systemd/system/atomic-openshift-node.service is referencing correct service type.

# cat /etc/systemd/system/atomic-openshift-node.service
[Unit]
After=atomic-openshift-master.service
After=container-engine.service
After=openvswitch.service
PartOf=container-engine.service
Requires=container-engine.service
Requires=openvswitch.service
After=ovsdb-server.service
After=ovs-vswitchd.service
Wants=atomic-openshift-master.service
Requires=atomic-openshift-node-dep.service
After=atomic-openshift-node-dep.service

<--snip-->

Comment 6 errata-xmlrpc 2017-08-10 05:23:08 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1716