Bug 1448811 - Container FailedSync events no longer supported but still present in UI
Summary: Container FailedSync events no longer supported but still present in UI
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Control
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.9.0
Assignee: Greg McCullough
QA Contact: Shalom Naim
URL:
Whiteboard: container
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-08 08:57 UTC by Beni Paskin-Cherniavsky
Modified: 2018-04-09 08:51 UTC (History)
6 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-01 13:12:04 UTC
Category: ---
Cloudforms Team: Container Management
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2018:0380 0 normal SHIPPED_LIVE Moderate: Red Hat CloudForms security, bug fix, and enhancement update 2018-03-01 18:37:12 UTC

Description Beni Paskin-Cherniavsky 2017-05-08 08:57:03 UTC
Description of problem:
FailedSync events proved too spammy and were blacklisted on master, 5.8, 5.7 by
https://github.com/ManageIQ/manageiq/pull/14633
However UI still shows them, and lets you create policies reacting to them.  Such policies will never fire because the event is no longer collected.

How reproducible: 100%

Steps to Reproduce:
1. Control -> Explorer -> Policies accordion -> create a Pod Control policy
2. assign Pod Failed Sync event
3. assign an action (eg. Generate Log) to the event
4. create a pod in kubernetes with a non-existant image name

Actual results:
`oc get events` will show a stream of FailedSync events.
Yet the policy will never run, can be seen in CFME's policy.log.

Expected results:
If you can create a policy, it should work.
Assuming we don't want this event, we should remove it from UI.

- I think removing from miq_event_definitions.csv seed won't delete it,
  we'll need a migration.  This means unfixable in 5.7 & 5.8?
- What to do with existing policies?
  A migration would have to unassign the event from existing policies,
  and it can add a note to such policies' notes field.

Comment 2 Federico Simoncelli 2017-05-08 20:44:49 UTC
Beni, implementation-wise let's split this in backportable (remove from UI) to be targeted for 5.8.z and non-backportable that we'll keep for 5.9.

I am assigning this to Zahi because I suppose you haven't started working on this. In case Beni you have a PR feel free to re-assign to you.

Comment 3 Beni Paskin-Cherniavsky 2017-05-09 08:19:44 UTC
haven't started any work.

Comment 5 zakiva 2017-06-07 08:33:10 UTC
(In reply to zakiva from comment #4)
> https://github.com/ManageIQ/manageiq/pull/15089

PR was merged to master. 
I don't think there is a way to remove the event from the UI without a migration, so we may have a problem with backporting this.
Moving to POST.

Comment 14 errata-xmlrpc 2018-03-01 13:12:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0380


Note You need to log in before you can comment on or make changes to this bug.