RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/
Bug 1448896 - Review Request: puppet-murano puppet module to install and configure Murano service
Summary: Review Request: puppet-murano puppet module to install and configure Murano s...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: trunk
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: trunk
Assignee: Javier Peña
QA Contact: hguemar
URL:
Whiteboard:
Depends On: RDO-PIKE
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-08 14:40 UTC by Alfredo Moralejo
Modified: 2017-05-29 10:09 UTC (History)
1 user (show)

Fixed In Version: puppet-murano-11.1.0-0.20170523171003.69d252a.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-29 10:09:16 UTC
Embargoed:
jpena: rdo-review+


Attachments (Terms of Use)

Description Alfredo Moralejo 2017-05-08 14:40:11 UTC
Murano Project introduces an application catalog, which allows application developers and cloud administrators to publish various cloud-ready applications in a browsable categorised catalog

The Murano module is a part of OpenStack, an effort by the OpenStack infrastructure team to provide continuous integration testing and code review for OpenStack and OpenStack community projects as part of the core software. The module itself is used to flexibly configure and manage the application catalog service for OpenStack.

Upstream project: https://github.com/openstack/puppet-murano

Comment 1 Alfredo Moralejo 2017-05-08 14:43:42 UTC
puppet-murano is used in puppet-openstack-integration so we need it to run it using puppet modules from rpm packages instead of deploying them from source.

Comment 2 Alfredo Moralejo 2017-05-08 15:00:47 UTC
Output of licensecheck:

$ licensecheck -r .
./.gitreview: *No copyright* UNKNOWN
./CHANGELOG.md: *No copyright* UNKNOWN
./Gemfile: *No copyright* UNKNOWN
./LICENSE: Apache (v2.0)
./README.md: *No copyright* UNKNOWN
./Rakefile: *No copyright* UNKNOWN
./metadata.json: *No copyright* UNKNOWN
./setup.cfg: *No copyright* Apache
./setup.py: Apache (v2.0) GENERATED FILE
./test-requirements.txt: *No copyright* UNKNOWN
./tox.ini: *No copyright* UNKNOWN
./manifests/api.pp: *No copyright* UNKNOWN
./manifests/application.pp: *No copyright* UNKNOWN
./manifests/cfapi.pp: *No copyright* UNKNOWN
./manifests/client.pp: *No copyright* UNKNOWN
./manifests/config.pp: *No copyright* UNKNOWN
./manifests/dashboard.pp: *No copyright* UNKNOWN
./manifests/db.pp: *No copyright* UNKNOWN
./manifests/db_cfapi.pp: *No copyright* UNKNOWN
./manifests/deps.pp: *No copyright* UNKNOWN
./manifests/engine.pp: *No copyright* UNKNOWN
./manifests/init.pp: *No copyright* UNKNOWN
./manifests/logging.pp: *No copyright* UNKNOWN
./manifests/logging_cfapi.pp: *No copyright* UNKNOWN
./manifests/params.pp: *No copyright* UNKNOWN
./manifests/policy.pp: *No copyright* UNKNOWN
./spec/shared_examples.rb: *No copyright* UNKNOWN
./spec/spec_helper.rb: *No copyright* UNKNOWN
./spec/spec_helper_acceptance.rb: *No copyright* UNKNOWN
./templates/local_settings.py.erb: *No copyright* UNKNOWN
./manifests/db/mysql.pp: *No copyright* UNKNOWN
./manifests/db/mysql_cfapi.pp: *No copyright* UNKNOWN
./manifests/db/postgresql.pp: *No copyright* UNKNOWN
./manifests/db/postgresql_cfapi.pp: *No copyright* UNKNOWN
./manifests/db/sync.pp: *No copyright* UNKNOWN
./manifests/db/sync_cfapi.pp: *No copyright* UNKNOWN
./manifests/keystone/auth.pp: *No copyright* UNKNOWN
./manifests/keystone/cfapi_auth.pp: *No copyright* UNKNOWN
./releasenotes/notes/add_messaging_default_parameters-9175a1238d4615f7.yaml: *No copyright* UNKNOWN
./releasenotes/notes/add_messaging_notification_parameters-a23983453ad76fe1.yaml: *No copyright* UNKNOWN
./releasenotes/notes/admin_param-3cf729b707a3abcd.yaml: *No copyright* UNKNOWN
./releasenotes/notes/cloudfoundry-6f274f6bdc48274e.yaml: *No copyright* UNKNOWN
./releasenotes/notes/configurable_dashboard_log_handler-43513e7b29028b4e.yaml: *No copyright* UNKNOWN
./releasenotes/notes/configurable_user_and_role-8e755bb0b27d267f.yaml: *No copyright* UNKNOWN
./releasenotes/notes/dashboard-label-60e3afe5a9de0339.yaml: *No copyright* UNKNOWN
./releasenotes/notes/deprecate_signing_dir_parameter-6135a343f233de98.yaml: *No copyright* UNKNOWN
./releasenotes/notes/drop_qpid-2698a74b1e99757b.yaml: *No copyright* UNKNOWN
./releasenotes/notes/external_install_mgmt_hook-ef172966391da942.yaml: *No copyright* UNKNOWN
./releasenotes/notes/fix_client_package_name-897d4c0a7c9a7cbf.yaml: *No copyright* UNKNOWN
./releasenotes/notes/fix_log_dir_documentation-ff5af59dfab3cbbb.yaml: *No copyright* UNKNOWN
./releasenotes/notes/fix_murano_application_update-8dfd1c4fe7839af1.yaml: *No copyright* UNKNOWN
./releasenotes/notes/fix_use_neutron-281638824d52ff8d.yaml: *No copyright* UNKNOWN
./releasenotes/notes/glare_api-f04ed81aadbb8904.yaml: *No copyright* UNKNOWN
./releasenotes/notes/keystone-auth-name-1111e1b65d4522eb.yaml: *No copyright* UNKNOWN
./releasenotes/notes/keystone-authtoken-memcached-eb3dc3fa52ecc2f2.yaml: *No copyright* UNKNOWN
./releasenotes/notes/keystone_versionless-34e97ee844df80ba.yaml: *No copyright* UNKNOWN
./releasenotes/notes/murano_cfapi_separate_config_file-ca0d487f0606b154.yaml: *No copyright* UNKNOWN
./releasenotes/notes/murano_cfapi_separate_db-550f9d1efc49e31b.yaml: *No copyright* UNKNOWN
./releasenotes/notes/network-driver-0ec3f27e3932f566.yaml: *No copyright* UNKNOWN
./releasenotes/notes/pymysql-e57bf1f0289dd426.yaml: *No copyright* UNKNOWN
./releasenotes/notes/rabbit-connection-params-deprecation-776dbae440e204ba.yaml: *No copyright* UNKNOWN
./releasenotes/notes/remove_verbose-9cf0281db23c507b.yaml: *No copyright* UNKNOWN
./releasenotes/notes/switch_to_oslo-1924a063b5008d56.yaml: *No copyright* UNKNOWN
./releasenotes/notes/syncdb-2cead6e859c38cb7.yaml: *No copyright* UNKNOWN
./releasenotes/notes/use-reno-1caaec4ba5aa4285.yaml: *No copyright* UNKNOWN
./releasenotes/notes/verbose-deprecation-908824a98df8331c.yaml: *No copyright* UNKNOWN
./releasenotes/source/conf.py: *No copyright* Apache (v2.0) GENERATED FILE
./releasenotes/source/index.rst: *No copyright* UNKNOWN
./releasenotes/source/mitaka.rst: *No copyright* UNKNOWN
./releasenotes/source/newton.rst: *No copyright* UNKNOWN
./releasenotes/source/ocata.rst: *No copyright* UNKNOWN
./releasenotes/source/unreleased.rst: *No copyright* UNKNOWN
./spec/acceptance/basic_murano_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_api_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_cfapi_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_client_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_config_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_dashboard_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_db_cfapi_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_db_mysql_cfapi_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_db_mysql_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_db_postgresql_cfapi_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_db_postgresql_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_db_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_db_sync_cfapi_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_db_sync_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_engine_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_init_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_keystone_auth_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_keystone_cfapi_auth_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_logging_cfapi_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_logging_spec.rb: *No copyright* UNKNOWN
./spec/classes/murano_policy_spec.rb: *No copyright* UNKNOWN
./spec/defines/murano_application_spec.rb: *No copyright* UNKNOWN
./spec/functions/get_ext_net_name_spec.rb: *No copyright* UNKNOWN
./lib/puppet/provider/murano.rb: *No copyright* UNKNOWN
./lib/puppet/type/murano_application.rb: *No copyright* UNKNOWN
./lib/puppet/type/murano_cfapi_config.rb: *No copyright* UNKNOWN
./lib/puppet/type/murano_cfapi_paste_ini_config.rb: *No copyright* UNKNOWN
./lib/puppet/type/murano_config.rb: *No copyright* UNKNOWN
./lib/puppet/type/murano_paste_ini_config.rb: *No copyright* UNKNOWN
./spec/acceptance/nodesets/centos-70-x64.yml: *No copyright* UNKNOWN
./spec/acceptance/nodesets/default.yml: *No copyright* UNKNOWN
./spec/acceptance/nodesets/nodepool-centos7.yml: *No copyright* UNKNOWN
./spec/acceptance/nodesets/nodepool-trusty.yml: *No copyright* UNKNOWN
./spec/acceptance/nodesets/nodepool-xenial.yml: *No copyright* UNKNOWN
./spec/acceptance/nodesets/ubuntu-server-1404-x64.yml: *No copyright* UNKNOWN
./spec/unit/provider/murano_spec.rb: *No copyright* UNKNOWN
./spec/unit/type/murano_application_spec.rb: *No copyright* UNKNOWN
./spec/unit/type/murano_cfapi_config_spec.rb: *No copyright* UNKNOWN
./spec/unit/type/murano_cfapi_paste_ini_config_spec.rb: *No copyright* UNKNOWN
./spec/unit/type/murano_config_spec.rb: *No copyright* UNKNOWN
./spec/unit/type/murano_paste_ini_config_spec.rb: *No copyright* UNKNOWN
./lib/puppet/parser/functions/get_ext_net_name.rb: *No copyright* UNKNOWN
./lib/puppet/provider/murano_application/murano.rb: *No copyright* UNKNOWN
./lib/puppet/provider/murano_cfapi_config/ini_setting.rb: *No copyright* UNKNOWN
./lib/puppet/provider/murano_cfapi_paste_ini_config/ini_setting.rb: *No copyright* UNKNOWN
./lib/puppet/provider/murano_config/ini_setting.rb: *No copyright* UNKNOWN
./lib/puppet/provider/murano_paste_ini_config/ini_setting.rb: *No copyright* UNKNOWN
./spec/unit/provider/murano_application/murano_spec.rb: *No copyright* UNKNOWN
./spec/unit/provider/murano_cfapi_config/ini_setting_spec.rb: *No copyright* UNKNOWN
./spec/unit/provider/murano_cfapi_paste_ini_config/ini_setting_spec.rb: *No copyright* UNKNOWN
./spec/unit/provider/murano_config/ini_setting_spec.rb: *No copyright* UNKNOWN
./spec/unit/provider/murano_paste_ini_config/ini_setting_spec.rb: *No copyright* UNKNOWN


License is ASL v2.0

Comment 4 Javier Peña 2017-05-12 15:53:40 UTC
Notes about the fedora-review output:

- The issue about python2-devel or python3-devel is due to the module including a setup.py file (not used in runtime or as a build requirement, just meant to be used for release notes, so not relevant.

- The license text is missing, since the spec was created by an automated tool. This is expected.

- The source url and %global definitions are expected, since the srpm was created by DLRN.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package contains BR: python2-devel or python3-devel
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
     generated". 78 files have unknown license. Detailed output of
     licensecheck in /tmp/puppet-murano/licensecheck.txt
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/openstack-puppet, /usr/share
     /openstack-puppet/modules
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/openstack-
     puppet/modules, /usr/share/openstack-puppet
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_version
     11.1.0-dev
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: puppet-murano-11.1.0-0.20170511133703.03b2a02.el7.centos.noarch.rpm
          puppet-murano-11.1.0-0.20170511133703.03b2a02.el7.centos.src.rpm
puppet-murano.noarch: E: explicit-lib-dependency puppet-openstacklib
puppet-murano.noarch: E: explicit-lib-dependency puppet-stdlib
puppet-murano.noarch: E: no-changelogname-tag
puppet-murano.noarch: W: no-documentation
puppet-murano.noarch: E: wrong-script-interpreter /usr/share/openstack-puppet/modules/murano/setup.py /usr/bin/env python
puppet-murano.noarch: E: non-executable-script /usr/share/openstack-puppet/modules/murano/setup.py 644 /usr/bin/env python
puppet-murano.src: E: no-changelogname-tag
puppet-murano.src: W: invalid-url Source0: 11.1.0-0.20170511133703.03b2a02.tar.gz
2 packages and 0 specfiles checked; 6 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
puppet-murano.noarch: E: explicit-lib-dependency puppet-openstacklib
puppet-murano.noarch: E: explicit-lib-dependency puppet-stdlib
puppet-murano.noarch: E: no-changelogname-tag
puppet-murano.noarch: W: no-documentation
puppet-murano.noarch: E: non-executable-script /usr/share/openstack-puppet/modules/murano/setup.py 0644L /usr/bin/env
1 packages and 0 specfiles checked; 4 errors, 1 warnings.



Requires
--------
puppet-murano (rpmlib, GLIBC filtered):
    puppet
    puppet-inifile
    puppet-keystone
    puppet-openstacklib
    puppet-oslo
    puppet-stdlib



Provides
--------
puppet-murano:
    puppet-murano



Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -n puppet-murano -m dlrn -r
Buildroot used: dlrn-centos7-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

The package is APPROVED.

Comment 5 Alfredo Moralejo 2017-05-29 10:09:16 UTC
Package published in centos-master RDO Trunk repo.


Note You need to log in before you can comment on or make changes to this bug.