Bug 1449145 - systemd: switch to libidn2
Summary: systemd: switch to libidn2
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: systemd
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: systemd-maint
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1468608
Blocks: fedora28-switch-to-idna2008
TreeView+ depends on / blocked
 
Reported: 2017-05-09 09:43 UTC by Nikos Mavrogiannopoulos
Modified: 2017-12-15 10:03 UTC (History)
8 users (show)

Fixed In Version: systemd-236-1.fc28
Clone Of:
Environment:
Last Closed: 2017-12-15 10:03:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Nikos Mavrogiannopoulos 2017-05-09 09:43:14 UTC
Description of problem:
Internationalized domain names exist for quite some time (IDNA2003), although the protocols describing them have evolved in an incompatible way (IDNA2008). These incompatibilities will prevent applications written for IDNA2003 to access certain problematic domain names defined with IDNA2008, e.g., faß.de is translated to domain xn--fa-hia.de with IDNA2008, while in IDNA2003 it is translated to fass.de domain. That not only causes incompatibility problems, but may be used as an attack vector to redirect users to different web sites.

The change is about deprecating libidn, which supports IDNA2003, and switch all applications using libidn, to libidn2 2.0.0, which supports IDNA2008. The switch should be transparent as the libidn2 library is API compatible. See instructions at:
https://libidn.gitlab.io/libidn2/manual/libidn2.html#Converting-from-libidn


This is part of the IDNA2008 change:
https://fedoraproject.org/wiki/Changes/IDNA2008

If upstream is not aware of that change please involve them on the process.

Comment 1 Zbigniew Jędrzejewski-Szmek 2017-05-10 02:01:19 UTC
https://github.com/systemd/systemd/pull/5928

Comment 2 Zbigniew Jędrzejewski-Szmek 2017-05-12 16:07:10 UTC
Will be fixed by systemd 234.

Comment 3 Zbigniew Jędrzejewski-Szmek 2017-07-13 13:48:23 UTC
I reverted the switch to libidn2 for now — we need to figure out the handling of "forbidden characters".

Comment 4 Nikos Mavrogiannopoulos 2017-07-20 07:16:51 UTC
https://gitlab.com/libidn/libidn2/issues/30

Comment 5 Nikos Mavrogiannopoulos 2017-08-10 06:49:17 UTC
Hi Zbigniew,
 Do you think this will be included in F27?

Comment 6 Zbigniew Jędrzejewski-Szmek 2017-08-10 19:34:07 UTC
Yes. I'll backport the patch. We recently noticed that there's an issue with the related tests in systemd, which will need to fixed. But it's all simple stuff, so there shouldn't be any problem.

Comment 7 Nikos Mavrogiannopoulos 2017-08-11 08:07:07 UTC
Thank you.

Comment 8 Jan Kurik 2017-08-15 09:07:58 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle.
Changing version to '27'.

Comment 9 Nikos Mavrogiannopoulos 2017-11-23 08:30:52 UTC
Hi Zbigniew,
 Was there any issue with backporting? Is fedora28 is feasible target?


Note You need to log in before you can comment on or make changes to this bug.