Bug 1449515 - When deleting a vm from an export domain the delete dialog is shown with a vm name as "null" (after performing some operations)
Summary: When deleting a vm from an export domain the delete dialog is shown with a vm...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.1.2
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.2.0
: ---
Assignee: Benny Zlotnik
QA Contact: Natalie Gavrielov
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-10 08:23 UTC by Natalie Gavrielov
Modified: 2017-12-20 11:47 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:47:00 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)
engine.log, console.log, snapshots (1.01 MB, application/zip)
2017-05-10 08:23 UTC, Natalie Gavrielov
no flags Details
screenshot (118.33 KB, image/png)
2017-08-30 15:11 UTC, Raz Tamir
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 77252 0 master MERGED webadmin: add a cleanup method for ImportVmGeneralSubTabView 2017-05-25 10:11:39 UTC
oVirt gerrit 81385 0 master MERGED webadmin: use a clone for ImportVmData entity 2017-10-15 14:12:17 UTC

Description Natalie Gavrielov 2017-05-10 08:23:49 UTC
Created attachment 1277566 [details]
engine.log, console.log, snapshots

Description of problem:
In a specific situation, when deleting a vm from an export domain the delete dialog is shown with a vm name as null.


Version-Release number of selected component:
rhevm-4.1.2-0.1.el7.noarch
vdsm-4.19.11-1.el7ev.x86_64

How reproducible:
100%

Steps to Reproduce:
Prerequisites: Have a vm in an export domain.
1. Connect to Webadmin, Storage tab, mark an export domain (this one was NFS based)
2. Go to lower pane, VM Import tab, Mark a VM, Click on Import - mark the vm to be imported in order to see it's properties, then in General tab, delete the name of the vm, and then click "Cancel" (dialog closes).
3. Now click on “Remove”.

Actual results:
The following dialog is displayed:
Are you sure you want to remove the following items?

- null

Expected results:
The following dialog to be displayed:
Are you sure you want to remove the following items?

- vm_TestCase4553_REST_NFS_0918481068

Additional info:
1. Adding another step: 4. click "cancel" in the remove dialog and then click on "Import" again. 
Result: shows the vm name as null also (snapshot attached).
2. Moving to another tab and switching back to this one "resets" the value (goes back to being the correct one).
3. When approving the deletion of the null vm - operation finishes successfully (the vm is indeed deleted).

Comment 1 Allon Mureinik 2017-05-25 16:19:54 UTC
Benny, the attached patch (https://gerrit.ovirt.org/#/c/77252) is merged. Are we waiting for additional patches, or should this BZ be moved to MODIFIED?

Comment 2 Benny Zlotnik 2017-05-25 17:42:44 UTC
Should be MODIFIED, not sure why it isn't

Comment 3 Raz Tamir 2017-08-30 15:11:01 UTC
Moving back to assign.

Tested on ovirt-engine-4.2.0-0.0.master.20170828065003.git0619c76.el7.centos

screenshot attached.

Followed the steps to reproduce and the bug still exists

Comment 4 Red Hat Bugzilla Rules Engine 2017-08-30 15:11:06 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 5 Raz Tamir 2017-08-30 15:11:30 UTC
Created attachment 1320148 [details]
screenshot

Comment 6 Raz Tamir 2017-08-30 15:13:06 UTC
Also,

After performing operation 1 - 3 and see the 'null', try to import the VM again, it is impossible now.

Raising severity

Comment 7 Allon Mureinik 2017-10-16 15:25:29 UTC
Benny - both patch attached here are merged.
Are we waiting for anything else, or should this be merged?

Comment 8 Allon Mureinik 2017-10-16 15:26:20 UTC
(In reply to Allon Mureinik from comment #7)
> Benny - both patch attached here are merged.
> Are we waiting for anything else, or should this be merged?
Frauding slip. Meant to ask whether this should be MODIFIED, of course. Mea culpa.

Comment 9 Benny Zlotnik 2017-10-16 15:42:35 UTC
Moving to MODIFIED

Comment 10 Natalie Gavrielov 2017-10-26 12:36:42 UTC
Verified, build: ovirt-engine-4.2.0-0.0.master.20171024223752.gite85d7f2.el7.centos.noarch

Comment 11 Sandro Bonazzola 2017-12-20 11:47:00 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.