Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1449675

Summary:	adding return statement in dict_unref() of libglusterfs/src/dict.c
Product:	[Community] GlusterFS	Reporter:	Sonal <sarora>
Component:	core	Assignee:	Sonal <sarora>
Status:	CLOSED DEFERRED	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	atumball, bugs, vbellur
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-05-14 09:33:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sonal 2017-05-10 12:35:15 UTC

Description of problem:
I am making a leak detetcion script which probes ref and unref functions and trace required variables.
It's easy to do this (in system tap) for those functions which are returning pointer, say for dict_ref(), its returning (dict_t *)this, so all the dict_t attributes are easily accessible using this *, but it's a bit tedious to do the same for those functions which are not returning pointer to structure. One such function is dict_unref.Thus added return statement in that.


Version-Release number of selected component (if applicable):
3.12

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
dict_unref() not returning this*.

Expected results:
It should return this *

Additional info:

Comment 1 Worker Ant 2017-05-15 13:39:33 UTC

REVIEW: https://review.gluster.org/17299 (Adding return statement to dict_unref(), returning (this*)dict_t. In leak detection script, it is more useful to probe at return statement to capture the state of some variables. Rest all ref /unref functions returns pointer as per requirement.) posted (#1) for review on master by Sonal Arora (sarora)

Comment 2 Amar Tumballi 2019-05-14 09:33:27 UTC

I see that this effort is not active.. marking as DEFERRED, please feel free to reopen it, once the work gets revisited.