Bug 1450106 - Pop-up with usercase occur if press "Edit" button after log collection via dropbox
Summary: Pop-up with usercase occur if press "Edit" button after log collection via dr...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.9.0
Assignee: Dávid Halász
QA Contact: Oleksii Tsuman
URL:
Whiteboard: log_collect:distributed
Depends On:
Blocks: 1460033
TreeView+ depends on / blocked
 
Reported: 2017-05-11 14:28 UTC by Oleksii Tsuman
Modified: 2018-03-06 15:01 UTC (History)
4 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1460033 (view as bug list)
Environment:
Last Closed: 2018-03-06 15:01:41 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Comment 2 CFME Bot 2017-05-23 11:33:31 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/1413
Comment 3 CFME Bot 2017-05-24 08:33:44 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/f1a6023b6e5d009257b2956ebec351895f6effc6

commit f1a6023b6e5d009257b2956ebec351895f6effc6
Author:     Dávid Halász <dhalasz>
AuthorDate: Tue May 23 11:27:30 2017 +0200
Commit:     Dávid Halász <dhalasz>
CommitDate: Tue May 23 18:39:32 2017 +0200

    Fixed prompt for log collection by reorganizing button inheritance
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1450106

 app/helpers/application_helper/button/collect_logs.rb         |  3 ++-
 app/helpers/application_helper/button/diagnostics_logs.rb     |  7 -------
 app/helpers/application_helper/button/log_depot_edit.rb       |  7 +++++++
 app/helpers/application_helper/button/logs.rb                 |  6 ------
 .../application_helper/button/mixins/button_prompt_mixin.rb   |  6 ++++++
 app/helpers/application_helper/button/zone_collect_logs.rb    |  3 ++-
 app/helpers/application_helper/button/zone_log_depot_edit.rb  |  7 -------
 .../application_helper/toolbar/diagnostics_server_center.rb   |  2 +-
 .../application_helper/toolbar/diagnostics_zone_center.rb     |  2 +-
 .../application_helper/buttons/diagnostics_logs_spec.rb       |  8 --------
 .../helpers/application_helper/buttons/log_depot_edit_spec.rb |  8 ++++++++
 .../application_helper/buttons/zone_log_depot_edit_spec.rb    | 11 -----------
 12 files changed, 27 insertions(+), 43 deletions(-)
 delete mode 100644 app/helpers/application_helper/button/diagnostics_logs.rb
 create mode 100644 app/helpers/application_helper/button/log_depot_edit.rb
 delete mode 100644 app/helpers/application_helper/button/logs.rb
 create mode 100644 app/helpers/application_helper/button/mixins/button_prompt_mixin.rb
 delete mode 100644 app/helpers/application_helper/button/zone_log_depot_edit.rb
 delete mode 100644 spec/helpers/application_helper/buttons/diagnostics_logs_spec.rb
 create mode 100644 spec/helpers/application_helper/buttons/log_depot_edit_spec.rb
 delete mode 100644 spec/helpers/application_helper/buttons/zone_log_depot_edit_spec.rb
Comment 5 Oleksii Tsuman 2017-10-19 19:25:09 UTC 
verified in 5.9.0.2.20171010190026_0413a06
Note You need to log in before you can comment on or make changes to this bug.