Bug 1450271 - Missing dependencies on command-line tools for converter plugin
Summary: Missing dependencies on command-line tools for converter plugin
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: qmmp
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Karel Volný
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: lame
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-12 05:57 UTC by Yaakov Selkowitz
Modified: 2017-06-08 14:00 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-06-08 14:00:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Yaakov Selkowitz 2017-05-12 05:57:21 UTC
The converter plugin uses some command-line tools by default:

https://sourceforge.net/p/qmmp-dev/code/HEAD/tree/trunk/qmmp/src/plugins/General/converter/presets.conf

Therefore, qmmp should have (at least weak) dependencies on flac, lame(*), opus-tools, vorbis-tools, and wavpack.

(*) lame was just added and is currently in buildroot overrides for F25 and F26.

Comment 1 Karel Volný 2017-05-12 11:53:33 UTC
good catch, thanks, I've never used that plugin so I had no clue it calls commandline tools (I'm out of my clones to assign one to code reviews :-))

I've chosen the weak dependencies, I'm not in favor of pulling in everything forcefully 'just in case'

- and while at it, suggesting the plugin-pack might be a good idea too

I don't think this is worth update in stable branches (but it could sneak along another fix if it comes); I have prepared the change locally and I'll add it in Rawhide when updating to next qmmp version (which I believe to be around the corner)

Comment 2 Yaakov Selkowitz 2017-05-12 15:11:46 UTC
(In reply to Karel Volný from comment #1)
> good catch, thanks, I've never used that plugin so I had no clue it calls
> commandline tools (I'm out of my clones to assign one to code reviews :-))

Me neither, I only discovered it when I was looking for packages that might benefit from LAME support.

> I've chosen the weak dependencies, I'm not in favor of pulling in everything
> forcefully 'just in case'
> 
> - and while at it, suggesting the plugin-pack might be a good idea too

Makes sense to me.

> I don't think this is worth update in stable branches (but it could sneak
> along another fix if it comes); I have prepared the change locally and I'll
> add it in Rawhide when updating to next qmmp version (which I believe to be
> around the corner)

It's certainly not urgent, thanks.


Note You need to log in before you can comment on or make changes to this bug.