Bug 1450290 - Add new repository is shown even when embedded ansible is not enabled.
Summary: Add new repository is shown even when embedded ansible is not enabled.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.9.0
Assignee: Harpreet Kataria
QA Contact: luke couzens
URL:
Whiteboard: ansible_embed
Depends On:
Blocks: 1451121
TreeView+ depends on / blocked
 
Reported: 2017-05-12 07:48 UTC by luke couzens
Modified: 2018-03-06 15:18 UTC (History)
6 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1451121 (view as bug list)
Environment:
Last Closed: 2018-03-06 15:18:54 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screen showing notificatoin (25.14 KB, image/png)
2017-05-12 07:48 UTC, luke couzens
no flags Details

Description luke couzens 2017-05-12 07:48:49 UTC
Created attachment 1278085 [details]
screen showing notificatoin

Description of problem:Add new repository is shown even when embedded ansible is not enabled. All other options are grayed out.


Version-Release number of selected component (if applicable):5.8.0.14


How reproducible:100%


Steps to Reproduce:
1.Provision appliance
2.nav to Automation-Ansible-Repos
3.Try to add new repo

Actual results:Add of Repository "test" was successfully initialized. Followed by Error message displayed in the notification events suggesting to check the logs for more details


Expected results:Either option disabled while embedded ansible is disabled or a notification saying 'embedded ansible is disabled'


Additional info:
This option used to be disabled in previous builds 5.8.0.11 was the last one I checked.

On another point if you enable ansible, add a repo then disable ansible it seems the other options then become available when you tick/select your repo. They do however all throw the same error in notifications.

Comment 4 CFME Bot 2017-05-15 20:28:28 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/c4bd99d041ac9490a2019e67fd72331a909bc3a4

commit c4bd99d041ac9490a2019e67fd72331a909bc3a4
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon May 15 12:56:27 2017 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon May 15 14:54:54 2017 -0400

    Changed if condition to rely on back-end method.
    
    Changed check to call back-end method "MiqRegion#role_active?" to decide whether button should be enabled/disabled
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1450290

 .../application_helper/button/embedded_ansible.rb  |  4 +--
 .../buttons/embedded_ansible_spec.rb               | 30 +++++++++++++++++-----
 2 files changed, 25 insertions(+), 9 deletions(-)

Comment 6 luke couzens 2017-10-11 16:02:11 UTC
Verified in 5.9.0.1


Note You need to log in before you can comment on or make changes to this bug.