Bug 1451230 - dialog for adding proxy in hosts Power management doesn't work properly
Summary: dialog for adding proxy in hosts Power management doesn't work properly
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.2.0
: 4.2.0
Assignee: Alexander Wels
QA Contact: Petr Matyáš
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-16 07:48 UTC by Lucie Leistnerova
Modified: 2017-12-22 07:20 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-20 10:47:16 UTC
oVirt Team: UX
Embargoed:
rule-engine: ovirt-4.2+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 71520 0 master MERGED webadmin: PowerManagement Fence proxy subdialog wont close 2017-05-22 18:33:41 UTC
oVirt gerrit 77129 0 master MERGED webadmin: layout fix Add Power Management Proxy dialog 2017-05-24 18:23:53 UTC

Comment 1 Martin Perina 2017-05-17 06:34:55 UTC 
Greg, could you please take a look? We haven't done any changes in that are for quite long time, can't this be related to some GWT refactoring?
Comment 2 Greg Sheremeta 2017-05-22 18:20:49 UTC 
Three bugs here.

1. the dialog layout is old-style. I posted a patch to fix this in https://gerrit.ovirt.org/#/c/77129

2. the Cancel button doesn't work. Clicking X does.

3. Upon adding a value, it's not removed from the list, and can be added again, causing an exception.

git blame shows it's mostly Alexander's code in HostProxySourceEditor -- assigning to him.
Comment 3 Vojtech Szocs 2017-05-22 19:07:54 UTC 
> 2. the Cancel button doesn't work. Clicking X does.

This was fixed by https://gerrit.ovirt.org/#/c/71520/
Comment 4 Petr Matyáš 2017-09-04 11:43:04 UTC 
Verified on ovirt-engine.noarch 0:4.2.0-0.0.master.20170903205106.gitb17261a.el7.centos

The dialog can be closed by clicking on either OK or Cancel and no UI exception appears.
Comment 5 Sandro Bonazzola 2017-12-20 10:47:16 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.