Bug 1451232 - long timeout when importing network with wrong provider credentials
Summary: long timeout when importing network with wrong provider credentials
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Backend.Core
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-4.2.0
: ---
Assignee: Dominik Holler
QA Contact: Mor
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-16 08:02 UTC by Mor
Modified: 2017-12-20 10:56 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-20 10:56:38 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)
import hangs screenshot (18.27 KB, image/png)
2017-05-22 10:19 UTC, Mor
no flags Details
logs (614.46 KB, application/x-gzip)
2017-05-22 10:33 UTC, Mor
no flags Details
failure on timeout (22.00 KB, image/png)
2017-06-11 07:15 UTC, Mor
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 77747 0 master MERGED React on communication failure on external network import 2017-06-08 08:34:43 UTC

Description Mor 2017-05-16 08:02:30 UTC
Description of problem:
When using wrong provider credentials, and trying to import networks without testing the provider connection first (using the test button), import window is stuck. This might be relevant for use cases OVN networks (For example, OVN network is used by VM and VM starts).

Version-Release number of selected component (if applicable):
oVirt Engine Version: 4.2.0-0.0.master.20170514192031.gitbcb4208.el7.centos

How reproducible:
100%

Steps to Reproduce:
1. Edit the provider and change username or password to wrong value.
2. Press OK (Do not press 'Test').

Actual results:
Provider is registered with wrong username or value.

Expected results:
Block OK if test not passed, otherwise, we should handle it on the engine side with different use scenarios.

Additional info:

Comment 1 Dan Kenigsberg 2017-05-16 08:09:14 UTC
(In reply to Mor from comment #0)
> When using wrong provider credentials, and trying to import networks without
> testing the provider connection first (using the test button), import window
> is stuck.

For how long? Dominik added a timeout to Engine-Provider communications.

Comment 2 Mor 2017-05-16 08:14:05 UTC
(In reply to Dan Kenigsberg from comment #1)
> (In reply to Mor from comment #0)
> > When using wrong provider credentials, and trying to import networks without
> > testing the provider connection first (using the test button), import window
> > is stuck.
> 
> For how long? Dominik added a timeout to Engine-Provider communications.

Is there any reason to allow saving the changes when the user enters wrong credentials? Also, about the timeout I tried waiting 2 minutes.

Comment 3 Dan Kenigsberg 2017-05-17 08:23:49 UTC
Yes, I can think of a user that defines the provider while the provider is offline. I do not want to force him to Test the connection immediately.

However, 2 minutes is a bit too long for Engine to notice that it has wrong credentials. Are you sure that the provider was on when the network is imported?

Comment 4 Mor 2017-05-17 08:41:07 UTC
(In reply to Dan Kenigsberg from comment #3)
> Yes, I can think of a user that defines the provider while the provider is
> offline. I do not want to force him to Test the connection immediately.
> 
> However, 2 minutes is a bit too long for Engine to notice that it has wrong
> credentials. Are you sure that the provider was on when the network is
> imported?

Yesm ovirt-provider-ovn was up and running.

Comment 5 Dan Kenigsberg 2017-05-21 11:32:03 UTC
Please supply engine.log, ovirt-provider-ovn.log, and the precise timeout (unless we have an even worse case, where Engine hangs forever).

Comment 6 Mor 2017-05-22 10:19:11 UTC
Seems like a case with import network action. If you have a registered provider with invalid settings, and choose to import a network from it, the window hangs waiting for the process to be completed.

Steps to reproduce:

1. Select the provider and set wrong password.
2. Networks --> Import and select the provider.

Window hangs on progress, even after 10 minutes wait.

Comment 7 Mor 2017-05-22 10:19:53 UTC
Created attachment 1280985 [details]
import hangs screenshot

Comment 8 Mor 2017-05-22 10:33:34 UTC
Created attachment 1280987 [details]
logs

Comment 9 Dominik Holler 2017-05-31 15:44:40 UTC
The ovirt-provider-ovn reacts instantly, as engine.log (search for "GetAllExternalNetworksOnProviderQuery") shows, but the reaction is not propagated to the UI.

Comment 10 Red Hat Bugzilla Rules Engine 2017-05-31 15:44:46 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 11 Mor 2017-06-11 07:14:56 UTC
Verified on version:
4.2.0-0.0.master.20170609091031.gitc86d08a.el7.centos

Comment 12 Mor 2017-06-11 07:15:35 UTC
Created attachment 1286751 [details]
failure on timeout

Comment 13 Sandro Bonazzola 2017-12-20 10:56:38 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.