RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1451394 - Can't use device name as 'top' device while merging active layer
Summary: Can't use device name as 'top' device while merging active layer
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Peter Krempa
QA Contact: Han Han
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-16 14:45 UTC by Denis Chaplygin
Modified: 2017-08-02 01:32 UTC (History)
5 users (show)

Fixed In Version: libvirt-3.2.0-6.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-02 00:08:25 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2017:1846 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2017-08-01 18:02:50 UTC

Description Denis Chaplygin 2017-05-16 14:45:01 UTC 
I have VM with storage, that contains several snapshots and i would like to merge active layer with first snapshot, using blockcommit function and refering to the layers using indices. Unfortunately i can't refer to the active layer as 'vda' (diskname) and have to pass empty value, so active layer is choosen by default




Version-Release number of selected component (if applicable):
Name        : libvirt
Arch        : x86_64
Version     : 2.0.0
Release     : 10.el7


How reproducible:
Always

Steps to Reproduce:
1. Create a VM and make several snapshots of it's storage.
2. virsh blockcommit vm sda --top sda --base "sda[1]" --active

Actual results:
invalid argument: could not find image 'sda'

Expected results:
Layers should be merged.
Comment 2 Peter Krempa 2017-05-17 15:43:10 UTC 
Fixed upstream:

commit ed61e0b368859b25beb5259f84edd4910cd5218f
Author: Peter Krempa <pkrempa>
Date:   Wed May 17 17:16:15 2017 +0200

    qemu: driver: Allow passing disk target as top image with block commit
    
    Since we allow active layer block commit the users are allowed to commit
    the top of the chain (e.g. vda) into the backing image. The API would
    not accept that parameter, as it tried to look up the image in the
    backing chain.
    
    Add the ability to use the top level image target name explicitly as the
    top image of the block commit operation.
Comment 5 Han Han 2017-06-13 01:25:30 UTC 
Verify it on libvirt-3.2.0-9.el7.x86_64:
1. Prepare a running VM:
# virsh list
 Id    Name                           State
----------------------------------------------------
 3     test                           running

2. Create external snapshots:
# virsh snapshot-create test --no-metadata --disk-only                                   
Domain snapshot 1497317009 created
# virsh snapshot-create test --no-metadata --disk-only
Domain snapshot 1497317011 created
# virsh snapshot-create test --no-metadata --disk-only
Domain snapshot 1497317013 created

3. Blockcommit with vda as top layer:
# virsh blockcommit test vda --top vda --base  "vda[2]" --active --verbose --wait --pivot
Block commit: [100 %]
Successfully pivoted

# virsh blockcommit test vda 100M "vda[1]" vda --verbose --wait --pivot                  
Block commit: [100 %]
Successfully pivoted

All works as expected.
Comment 6 errata-xmlrpc 2017-08-02 00:08:25 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846
Comment 7 errata-xmlrpc 2017-08-02 01:32:35 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846
Note You need to log in before you can comment on or make changes to this bug.