Bug 1451413 - Introduce limit on repeating end method on command callbacks
Summary: Introduce limit on repeating end method on command callbacks
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Backend.Core
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.0
: 4.2.0
Assignee: Ravi Nori
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-16 15:15 UTC by Ravi Nori
Modified: 2018-02-12 10:10 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2018-02-12 10:10:29 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 80724 0 master MERGED engine : Introduce limit on repeating end method on command callbacks 2017-09-21 08:24:27 UTC

Description Ravi Nori 2017-05-16 15:15:52 UTC
Description of problem: 

When command callback's onSucceeded or onFailed method throws an exception (like NullPointerException) and the callback has overridden shouldRepeatEndMethodsOnFail to return true, CommandCallbacksPoller keeps retrying the end method. This causes flooding in the logs for the failure to invoke the end method on the callback.


Expected results:

There should be a limit on the number of times CommandCallbacksPoller tries to execute the end method of the callback.

Comment 1 Sandro Bonazzola 2018-02-12 10:10:29 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.