Bug 1451485 - [RFE] [CodeChange] Consume PatternFly styling via official npm package
Summary: [RFE] [CodeChange] Consume PatternFly styling via official npm package
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-dashboard
Classification: oVirt
Component: RFEs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.0
: ---
Assignee: Scott Dickerson
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-16 18:54 UTC by Vojtech Szocs
Modified: 2017-12-20 11:04 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2017-12-20 11:04:27 UTC
oVirt Team: UX
Embargoed:
gshereme: ovirt-4.2?
pnovotny: testing_plan_complete-
rule-engine: planning_ack?
gshereme: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 84696 0 master MERGED Use Patternfly from official npm package 2017-11-29 19:05:28 UTC

Description Vojtech Szocs 2017-05-16 18:54:36 UTC 
Currently, we keep a copy of old RCUE .css files & fonts directly in the repo, treating them as static assets.

We consume PatternFly styling via official `patternfly` npm package, either taking .css files & fonts from it as-is (simpler), or add Less support to our build and consume the .less files (better, can be done later).
Comment 1 Vojtech Szocs 2017-05-16 18:55:53 UTC 
* We should consume PatternFly styling ... (sorry, typing too quickly)
Comment 2 Yaniv Kaul 2017-09-05 08:24:17 UTC 
Greg - what's the status of this RFE?
Comment 3 Greg Sheremeta 2017-09-05 13:19:10 UTC 
We haven't worked on it yet. I would like to fix this for 4.2.
Comment 4 Greg Sheremeta 2017-12-08 16:08:57 UTC 
QE: this is a CodeChange. To test, if the dashboard loads and looks normal (i.e. CSS is not missing), all good.
Comment 5 Pavel Novotny 2017-12-15 18:08:14 UTC 
Verified in
ovirt-engine-4.2.0.2-0.1.el7.noarch
ovirt-engine-dashboard-1.2.0-1.el7ev.noarch

No regressions were found in the Dashboard functionality.
The visual appearance looks well, no missing media, CSS or JS reported in the engine logs or browser console.
Comment 6 Sandro Bonazzola 2017-12-20 11:04:27 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.