Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1451485

Summary:	[RFE] [CodeChange] Consume PatternFly styling via official npm package
Product:	[oVirt] ovirt-engine-dashboard	Reporter:	Vojtech Szocs <vszocs>
Component:	RFEs	Assignee:	Scott Dickerson <sdickers>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavel Novotny <pnovotny>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	bugs, gshereme, oourfali
Target Milestone:	ovirt-4.2.0	Keywords:	CodeChange, FutureFeature
Target Release:	---	Flags:	gshereme: ovirt-4.2? pnovotny: testing_plan_complete- rule-engine: planning_ack? gshereme: devel_ack+ rule-engine: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-20 11:04:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	UX	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vojtech Szocs 2017-05-16 18:54:36 UTC

Currently, we keep a copy of old RCUE .css files & fonts directly in the repo, treating them as static assets.

We consume PatternFly styling via official `patternfly` npm package, either taking .css files & fonts from it as-is (simpler), or add Less support to our build and consume the .less files (better, can be done later).

Comment 1 Vojtech Szocs 2017-05-16 18:55:53 UTC

* We should consume PatternFly styling ... (sorry, typing too quickly)

Comment 2 Yaniv Kaul 2017-09-05 08:24:17 UTC

Greg - what's the status of this RFE?

Comment 3 Greg Sheremeta 2017-09-05 13:19:10 UTC

We haven't worked on it yet. I would like to fix this for 4.2.

Comment 4 Greg Sheremeta 2017-12-08 16:08:57 UTC

QE: this is a CodeChange. To test, if the dashboard loads and looks normal (i.e. CSS is not missing), all good.

Comment 5 Pavel Novotny 2017-12-15 18:08:14 UTC

Verified in
ovirt-engine-4.2.0.2-0.1.el7.noarch
ovirt-engine-dashboard-1.2.0-1.el7ev.noarch

No regressions were found in the Dashboard functionality.
The visual appearance looks well, no missing media, CSS or JS reported in the engine logs or browser console.

Comment 6 Sandro Bonazzola 2017-12-20 11:04:27 UTC

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.