Bug 145181 - plugin target/bin subtrees only takes 1 value
Summary: plugin target/bin subtrees only takes 1 value
Alias: None
Product: 389
Classification: Retired
Component: Server - Plugins
Version: 7.1
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Rich Megginson
QA Contact: Viktor Ashirov
Depends On:
Blocks: 389_1.2.6 639035
TreeView+ depends on / blocked
Reported: 2005-01-15 00:37 UTC by Rich Megginson
Modified: 2015-12-07 17:05 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2015-12-07 17:05:04 UTC

Attachments (Terms of Use)
0001-Bug-145181-Plugin-target-bind-subtrees-only-take-1-v.patch (8.58 KB, patch)
2010-04-19 21:58 UTC, Endi Sukma Dewata
rmeggins: review+
Details | Diff

Description Rich Megginson 2005-01-15 00:37:35 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2)
Gecko/20040805 Netscape/7.2

Description of problem:
The plugin configuration has target_subtrees and bind_subtrees, which
are supposed to be a list of subtrees to allow the plugin to operate
on (bind_subtrees for BIND/UNBIND, target_subtrees for all other
operations).  However, when getting the value from the attribute in
the plugin config entry, only the first value is retrieved e.g. it
uses slapi_entry_attr_get_charptr instead of
slapi_entry_attr_get_charray (or just iterating through the values). 
The rest of the code assumes 1 or more values, so it's probably an
easy fix.

One other thing that may be useful would be to have both included
subtrees and excluded subtrees.  For example, with the PAM plugin, you
would never want it to operate on o=NetscapeRoot and cn=config.  It
would be easier to specify those subtrees to be excluded that to
specifically include all the other subtrees.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
Config the plugin

Additional info:

Comment 1 Chandrasekar Kannan 2007-07-25 19:03:53 UTC
DS7.2 is not a valid milestone anymore. Anything thats set to DS7.2 should be
set to DS8.0. Will make further changes per bug council on 07/24/2007, after this.

Comment 6 Endi Sukma Dewata 2010-04-19 21:58:56 UTC
Created attachment 407690 [details]

New attributes nsslapd-exclude-targetSubtree and nsslapd-exclude-bindSubtree have been added to specify excluded subtrees. The set_plugin_config_from_entry() has been modified to read multiple subtrees. The plugin_invoke_plugin_sdn() and plugin_allow_internal_op() have been modified to check for excluded subtrees.

Comment 7 Rich Megginson 2010-04-26 23:47:31 UTC
commit 1d7f7f52485922e9fa992de0e74ede1d44b81097
Author: Endi S. Dewata <edewata@redhat.com>
Date:   Sat Apr 17 00:08:35 2010 -0500

Comment 8 Rich Megginson 2010-04-27 17:27:34 UTC
I don't think we need this for 8.2 - it can wait for 9.0

Comment 10 Rich Megginson 2011-07-15 16:54:20 UTC
yeah, just mark as verifiedupstream - we don't have any plugins that take advantage of this

Note You need to log in before you can comment on or make changes to this bug.