RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1452048 - qemu abort when hot unplug block device during live commit
Summary: qemu abort when hot unplug block device during live commit
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: qemu-kvm-rhev
Version: 7.4
Hardware: All
OS: Linux
urgent
high
Target Milestone: rc
: ---
Assignee: Kevin Wolf
QA Contact: Qianqian Zhu
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-18 08:42 UTC by Qianqian Zhu
Modified: 2017-08-02 04:41 UTC (History)
10 users (show)

Fixed In Version: qemu-kvm-rhev-2.9.0-10.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-02 04:41:00 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2017:2392 0 normal SHIPPED_LIVE Important: qemu-kvm-rhev security, bug fix, and enhancement update 2017-08-01 20:04:36 UTC

Description Qianqian Zhu 2017-05-18 08:42:52 UTC
Description of problem:
qemu abort when hot unplug block device during live commit.

Version-Release number of selected component (if applicable):
kernel-3.10.0-640.el7.x86_64
qemu-kvm-rhev-2.9.0-5.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Launch guest
(gdb) run -name 'avocado-vt-vm1' \
    -vga cirrus \
    -device virtio-scsi-pci,id=virtio_scsi_pci0,bus=pci.0,addr=03 \
    -drive id=drive_image1,if=none,snapshot=off,aio=native,cache=none,format=raw,file=/home/kvm_autotest_root/images/rhel74-64-virtio-scsi.raw \
    -device scsi-hd,id=image1,drive=drive_image1 \
    -device virtio-net-pci,mac=9a:ac:ad:ae:af:b0,id=idqKTtyC,vectors=4,netdev=idBAxKKY,bus=pci.0,addr=04 \
    -netdev tap,id=idBAxKKY,vhost=on \
    -m 4096 \
    -smp 4,cores=2,threads=1,sockets=2 \
    -cpu 'SandyBridge',+kvm_pv_unhalt \
    -vnc :0 \
    -rtc base=utc,clock=host,driftfix=slew \
    -boot order=cdn,once=c,menu=off,strict=off \
    -monitor stdio \
    -qmp tcp::5555,server,nowait

2. Live snapshot:
{ "execute": "blockdev-snapshot-sync", "arguments": { "device": "drive_image1","snapshot-file": "/mnt/iscsi/sn1", "format": "qcow2", "mode": "absolute-paths" } }
{"return": {}}
{ "execute": "blockdev-snapshot-sync", "arguments": { "device": "drive_image1","snapshot-file": "/mnt/iscsi/sn2", "format": "qcow2", "mode": "absolute-paths" } }
{"return": {}}
{ "execute": "blockdev-snapshot-sync", "arguments": { "device": "drive_image1","snapshot-file": "/mnt/iscsi/sn3", "format": "qcow2", "mode": "absolute-paths" } }

dd a 1G file on sn3.

{ "execute": "blockdev-snapshot-sync", "arguments": { "device": "drive_image1","snapshot-file": "/mnt/iscsi/sn4", "format": "qcow2", "mode": "absolute-paths" } }

3. Live commit from sn3 to sn1:
{ "execute": "block-commit", "arguments": { "device": "drive_image1", "base": "/mnt/iscsi/sn1", "top": "/mnt/iscsi/sn3"}}

4. Hot unplug the block device:
{ "execute": "device_del", "arguments": { "id": "image1"}}


Actual results:
qemu abort:
main-loop: WARNING: I/O thread spun for 1000 iterations
[New Thread 0x7ffedf9ff700 (LWP 26964)]
qemu-kvm: block.c:1894: bdrv_attach_child: Assertion `parent_bs->drv' failed.

Program received signal SIGABRT, Aborted.
0x00007fffed4b81f7 in raise () from /lib64/libc.so.6


Expected results:
Hot unplug succeeds, block job being cancelled.

Additional info:
qemu-kvm-rhev-2.6.0-27.el7.x86_64 has no this issue, so this is a regression.

Comment 3 Ademar Reis 2017-05-22 17:04:29 UTC
Looks like an assertion added by the new op-blockers:

commit f68c598be6a48995ca4c7cc42fc1f6e1195ec7aa
Author: Kevin Wolf <kwolf>
Date:   Tue Dec 20 15:51:12 2016 +0100

    block: Request real permissions in bdrv_attach_child()
    
    Now that all block drivers with children tell us what permissions they
    need from each of their children, bdrv_attach_child() can use this
    information and make the right requirements while trying to attach new
    children.
    
    Signed-off-by: Kevin Wolf <kwolf>
    Acked-by: Fam Zheng <famz>
    Reviewed-by: Max Reitz <mreitz>

Comment 4 Kevin Wolf 2017-06-12 13:35:46 UTC
I fixed this in upstream commit 19ebd13e. Posted a backport now.

Comment 6 Miroslav Rezanina 2017-06-13 16:35:11 UTC
Fix included in qemu-kvm-rhev-2.9.0-10.el7

Comment 7 Qianqian Zhu 2017-06-14 05:35:03 UTC
Verified with:
qemu-kvm-rhev-2.9.0-10.el7.x86_64
kernel-3.10.0-679.el7.x86_64

Steps:
Same as comment 0.
Results:
As expected, Hot unplug succeeds, block job is cancelled.

Comment 10 Qianqian Zhu 2017-06-16 06:18:32 UTC
Moving to VERIFIED per comment 7 and comment 9.

Comment 12 errata-xmlrpc 2017-08-02 04:41:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:2392


Note You need to log in before you can comment on or make changes to this bug.