Bug 1452584 - [Ansible Embedded] - Remove ssh keys fields from SCM credentials form
Summary: [Ansible Embedded] - Remove ssh keys fields from SCM credentials form
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.9.0
Assignee: Zita Nemeckova
QA Contact: Dmitry Misharov
URL:
Whiteboard: ansible_embed:ui
Depends On:
Blocks: 1462779
TreeView+ depends on / blocked
 
Reported: 2017-05-19 09:22 UTC by Pavol Kotvan
Modified: 2018-03-06 15:12 UTC (History)
10 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1462779 (view as bug list)
Environment:
Last Closed: 2018-03-06 15:12:27 UTC
Category: Bug
Cloudforms Team: Ansible
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Pavol Kotvan 2017-05-19 09:22:13 UTC
Description of problem:
Because we support only http/https protocols for cloning git repositories, it makes no sense to have Private key and Private key Passphrase fields in SCM credentials form

Version-Release number of selected component (if applicable):
5.8.0.15.20170517161141_119e6fd

How reproducible:
always

Steps to Reproduce:
1. Enable Ansible Embedded role
2. Navigate to Automation - Ansible - Credentials 
3. Configuration - Add new credentials, choose SCM credential type

Actual results:
This fields have no use, because git+ssh won't be supported by CFME UI.

Expected results:
Remove Private key and Private key Passphrase fields from SCM credentials form

Additional info:

Comment 2 Milan Zázrivec 2017-05-23 11:35:16 UTC
The embedded Ansible credentials form is completely data driven
by whatever comes from backend (api). If those two fields aren't
meant to be in the form (which I'm not sure is correct, I do not see
this being approved by product management), this needs to be
changed on the backend.

Comment 3 Bronagh Sorota 2017-05-25 16:40:34 UTC
Hi James,
Note this is a blocker bug for the 5.8.1 release.

Thanks
Bronagh

Comment 4 James Wong 2017-05-25 16:57:39 UTC
Backend doesn't impose any limitation on protocols that we support. It is UI imposing the limitation on the protocols. 

My recommendation would be that: since this knowledge resides in UI, the removal of these fields should stay with UI.

Let me know

Comment 6 Dan Clarizio 2017-05-31 19:34:12 UTC
Jason, I'm pretty sure I recall something about not carrying the keys inside cloudforms for git access, that's why we don't support git URLs yet.  If this is the case, I'm thinking the back end should not provide these fields yet until we have a solution.  Hacking the front end to remove the ssh key fields doesn't seem right as, once the back end can handle the support, we won't need to remember to go back and change the UI code.

I'm willing to do it on the front end, but would like your opinion.

Thx, Dan

Comment 7 Jason Frey 2017-06-05 15:03:13 UTC
I think there is a misunderstanding from all sides here.

Initially, during the requirements phase, we had wanted to avoid developing for SCM credentials, in order to pare down the problem and to fit the release time frame, so we imposed the limitation of http/https.  However, during the development phase we realized that we needed the SCM credentials modeled anyway, so we went ahead with it.  I spoke with James, and it is my understanding that the backend can support SSH as well as http/https.  Thus, since the UI is already exposing this, SSH should just work and just needs to be tested and verified.

I think the issue here is that the initial assumption of the BZ issue is invalid:

> we support only http/https protocols for cloning git repositories

Comment 8 Dan Clarizio 2017-06-13 20:32:28 UTC
Pavol, can you please try to verify what Jason says above? Let me know if the UI won't allow a git type URL to be entered as we can fix that, but if it does allow it, then the SSH keys should work.  Thx, Dan

Comment 16 Dmitry Misharov 2017-10-13 11:48:33 UTC
Verified in 5.9.0.2.20171010190026_0413a06. The UI accepts ssh urls like git:jonnyfiveiq/Ansible_Playbooks, but the backend can't pull playbooks.


Note You need to log in before you can comment on or make changes to this bug.