Bug 1452631 - specParams of memory devices 'size' and 'node' are of wrong type
Summary: specParams of memory devices 'size' and 'node' are of wrong type
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.2.0
: 4.2.0
Assignee: jniederm
QA Contact: Israel Pinto
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-19 11:26 UTC by jniederm
Modified: 2017-12-22 07:30 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:32:39 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)
stacktrace.txt (16.74 KB, text/plain)
2017-05-19 11:26 UTC, jniederm
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 76640 0 master MERGED core: Memory device specParams int -> String 2017-06-08 15:04:02 UTC
oVirt gerrit 76985 0 master MERGED webadmin: Memory hotunplug button and missing specParams 2017-06-09 09:04:12 UTC
oVirt gerrit 77022 0 master MERGED core: Validation of 'size' specParam in HotUnplugMemoryCommand 2017-06-08 16:12:26 UTC
oVirt gerrit 77038 0 master MERGED webadmin: Hotunplug button works with String specParams 2017-06-08 16:12:30 UTC

Description jniederm 2017-05-19 11:26:31 UTC
Created attachment 1280373 [details]
stacktrace.txt

Description of problem:
'size' and 'node' specParams of memory devices are stored as ints instead of Strings. This prevents these properties from serialization to OVF format, resulting in missing specParams properties in previewed snapshot.

Missing 'size' specParam can lead to NPE in engine during memory hotplug.

Version-Release number of selected component (if applicable):
4.2 master, commit 321ec24

How reproducible:
100%

Steps to Reproduce:
1. Create vm and run it
2. Hotplug memory
3. Create a snapshot with memory
4. Stop the vm
5. Start the vm
6. Stop the vm
7. Preview the snapshot without memory
8. Start the vm
9. Hotplug memory

Actual results:
Error popup "Error while executing action Edit VM properties: Internal Engine Error". See attachment for engine stacktrace

Expected results:
Second memory hot-plug passes

Additional info:
This bug is about wrong type of specParams. Steps to reproduce leads to engine NPE that is result of multiple problems:
* missing specParam 'size'
* previewing a snapshot doesn't clear vm device monitoring cache 
  OR memory devices are imported during snapshot preview without memory

Missing specParams also prevent hotunplug of memory devices from vm that preview snapshot with memory.

Comment 1 Tomas Jelinek 2017-05-24 12:13:15 UTC
the real issue with this bug shows up only with the hot unplug feature which will land only in 4.2 so targeting also this to 4.2

Comment 2 Israel Pinto 2017-09-26 06:17:39 UTC
Verify with:
Software version:4.2.0-0.0.master.20170917124606.gita804ef7.el7.centos


Steps to Reproduce:
1. Create vm and run it
2. Hotplug memory
3. Create a snapshot with memory
4. Stop the vm
5. Start the vm
6. Stop the vm
7. Preview the snapshot with memory
8. Start the vm
9. Hotplug memory
10. Run steps 1-9 with snapshot without memory

Results:
PASS

Comment 3 Sandro Bonazzola 2017-12-20 11:32:39 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.