Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1452631

Summary: specParams of memory devices 'size' and 'node' are of wrong type
Product: [oVirt] ovirt-engine Reporter: jniederm
Component: BLL.VirtAssignee: jniederm
Status: CLOSED CURRENTRELEASE QA Contact: Israel Pinto <ipinto>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.2.0CC: bugs, tjelinek
Target Milestone: ovirt-4.2.0Flags: rule-engine: ovirt-4.2+
Target Release: 4.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-20 11:32:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
stacktrace.txt none

Description jniederm 2017-05-19 11:26:31 UTC
Created attachment 1280373 [details]
stacktrace.txt

Description of problem:
'size' and 'node' specParams of memory devices are stored as ints instead of Strings. This prevents these properties from serialization to OVF format, resulting in missing specParams properties in previewed snapshot.

Missing 'size' specParam can lead to NPE in engine during memory hotplug.

Version-Release number of selected component (if applicable):
4.2 master, commit 321ec24

How reproducible:
100%

Steps to Reproduce:
1. Create vm and run it
2. Hotplug memory
3. Create a snapshot with memory
4. Stop the vm
5. Start the vm
6. Stop the vm
7. Preview the snapshot without memory
8. Start the vm
9. Hotplug memory

Actual results:
Error popup "Error while executing action Edit VM properties: Internal Engine Error". See attachment for engine stacktrace

Expected results:
Second memory hot-plug passes

Additional info:
This bug is about wrong type of specParams. Steps to reproduce leads to engine NPE that is result of multiple problems:
* missing specParam 'size'
* previewing a snapshot doesn't clear vm device monitoring cache 
  OR memory devices are imported during snapshot preview without memory

Missing specParams also prevent hotunplug of memory devices from vm that preview snapshot with memory.

Comment 1 Tomas Jelinek 2017-05-24 12:13:15 UTC
the real issue with this bug shows up only with the hot unplug feature which will land only in 4.2 so targeting also this to 4.2

Comment 2 Israel Pinto 2017-09-26 06:17:39 UTC
Verify with:
Software version:4.2.0-0.0.master.20170917124606.gita804ef7.el7.centos


Steps to Reproduce:
1. Create vm and run it
2. Hotplug memory
3. Create a snapshot with memory
4. Stop the vm
5. Start the vm
6. Stop the vm
7. Preview the snapshot with memory
8. Start the vm
9. Hotplug memory
10. Run steps 1-9 with snapshot without memory

Results:
PASS

Comment 3 Sandro Bonazzola 2017-12-20 11:32:39 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.