Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1452772 - [RFE] Passenger graceful killer cron job
[RFE] Passenger graceful killer cron job
Status: CLOSED ERRATA
Product: Red Hat Satellite 6
Classification: Red Hat
Component: Infrastructure (Show other bugs)
6.2.0
Unspecified Unspecified
unspecified Severity high (vote)
: GA
: Unused
Assigned To: Ivan Necas
Peter Ondrejka
: FutureFeature, Triaged
: 1452665 1452771 1630958 (view as bug list)
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-05-19 11:15 EDT by pm-sat@redhat.com
Modified: 2018-10-16 11:28 EDT (History)
9 users (show)

See Also:
Fixed In Version: rubygem-foreman_maintain-0.2.9-2
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2018-10-16 11:27:32 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Foreman Issue Tracker 19496 None None None 2017-05-19 11:15 EDT
Foreman Issue Tracker 24984 None None None 2018-09-19 10:46 EDT
Red Hat Product Errata RHSA-2018:2927 None None None 2018-10-16 11:28 EDT

  None (edit)
Description pm-sat@redhat.com 2017-05-19 11:15:33 EDT
Passenger open-source version does support process restarting on memory threshold. It looks like passenger have reserved SIGUSR1 for graceful restart. A cron job could do the job easily:

https://gist.github.com/kascote/366441

http://mensfeld.pl/2012/08/simple-rubyrails-passenger-memory-consumption-limit-monitoring/
Comment 1 pm-sat@redhat.com 2017-05-19 11:15:38 EDT
Created from redmine issue http://projects.theforeman.org/issues/19496
Comment 2 pm-sat@redhat.com 2017-05-19 11:15:41 EDT
Upstream bug assigned to lzap@redhat.com
Comment 3 Bryan Kearney 2017-05-19 11:16:47 EDT
*** Bug 1452771 has been marked as a duplicate of this bug. ***
Comment 4 Bryan Kearney 2017-05-19 11:17:07 EDT
*** Bug 1452665 has been marked as a duplicate of this bug. ***
Comment 5 Lukas Zapletal 2017-05-22 02:59:06 EDT
Thanks, is this meant for 6.3 or 6.2? This is easily backportable, just a script and packaging change.
Comment 6 pm-sat@redhat.com 2017-11-02 16:24:00 EDT
Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/19496 has been resolved.
Comment 7 Matt Pusateri 2018-09-18 17:00:04 EDT
Dev, can we get some assistance on how to reproduce pushing passenger into the failed state.
Comment 8 Lukas Zapletal 2018-09-19 10:31:03 EDT
Dumb approach, set the memory limit in this script to 400 MB, restart Satellite httpd and run

watch passenger-status

Click in the UI randomly, do some actions via CLI/API to increase memory consumption above 400 MB and then wait until the script gets executed from cron (or execute it). It should restart one process per execution.

The config is /etc/passenger-recycler.yaml and value you want to change is MAX_PRIV_RSS_MEMORY. Here is an example file:

https://github.com/swapab/foreman_maintain/blob/302581759bf5bc31de962f6cc5ccecb889c84748/config/passenger-recycler.yaml

It looks like for some reason this YAML file is not being distributed with foreman-maintain, likely a bug.
Comment 10 Lukas Zapletal 2018-09-19 11:19:08 EDT
Correction of the YAML file link:

https://github.com/theforeman/foreman_maintain/blob/master/config/passenger-recycler.yaml

Filed BZ#1630958 for the missing YAML file.
Comment 11 Ivan Necas 2018-09-19 11:32:38 EDT
*** Bug 1630958 has been marked as a duplicate of this bug. ***
Comment 12 pm-sat@redhat.com 2018-09-19 12:05:52 EDT
Upstream bug assigned to inecas@redhat.com
Comment 13 pm-sat@redhat.com 2018-09-19 12:05:56 EDT
Upstream bug assigned to inecas@redhat.com
Comment 15 Patrick Creech 2018-09-20 20:40:01 EDT
adding sat-maintenance flag as the above pr deals with foreman-maintain
Comment 16 Peter Ondrejka 2018-09-24 09:04:44 EDT
Verified on Satellite 6.4 snap 23, expected files are present: 

rpm -ql rubygem-foreman_maintain-0.2.10-1.el7sat.noarch | grep passenger
/etc/passenger-recycler.yaml
/usr/bin/passenger-recycler
/usr/share/gems/gems/foreman_maintain-0.2.10/bin/passenger-recycler
/usr/share/gems/gems/foreman_maintain-0.2.10/config/passenger-recycler.yaml
/usr/share/gems/gems/foreman_maintain-0.2.10/definitions/procedures/passenger_recycler.rb

With setup suggested in comment #8, running passenger-recycler:
...
Terminating 15319 (started 08:22:44) with private RSS size of 459 MB
Process successfully 15319 terminated
...

So the custom memory limit is respected. The cron task is not set automatically with rpm installation, however this is intended, as per discussion with inecas
Comment 18 errata-xmlrpc 2018-10-16 11:27:32 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2927

Note You need to log in before you can comment on or make changes to this bug.