Description of problem: Commit 76ddcbc271[1] breaks conditions in install_on_redhat.yml[2] related to following tasks (and maybe also something else): * install distro or red hat storage ceph mon * install distro or red hat storage ceph osd * install distro or red hat storage ceph mds * install distro or red hat storage ceph-fuse * install distro or red hat storage ceph base Now the condition for example for installation of 'ceph-mon' package looks like this: when: - mon_group_name in group_names or ceph_origin == "distro" or ceph_custom Which means, install ceph-mon package on system which is in mon group *OR* if ceph_origin == "distro". There should be logical AND instead of OR. Version-Release number of selected component (if applicable): ceph-ansible-2.2.6-1.el7scon.noarch It was broken by commit 76ddcbc271[1]. How reproducible: 100% Steps to Reproduce: 1. Try to create Ceph cluster via ceph-ansible (with ceph_origin set to "distro"). Actual results: The Ceph create cluster task fails on following (and similar) error, when try to install ceph-osd on monitor node: fatal: [mon1.example.com]: FAILED! => { "changed": false, "failed": true, "invocation": { "module_args": { "conf_file": null, "disable_gpg_check": false, "disablerepo": null, "enablerepo": null, "exclude": null, "install_repoquery": true, "list": null, "name": [ "ceph-osd" ], "state": "present", "update_cache": false, "validate_certs": true } }, "msg": "No package matching 'ceph-osd' found available, installed or updated", "rc": 126, "results": [ "No package matching 'ceph-osd' found available, installed or updated" ] } Expected results: ceph-ansible will install particular ceph packages on particular node accordingly to goroup/role assigned to the node Additional info: [1] https://github.com/ceph/ceph-ansible/commit/76ddcbc2719d316b7746f2d4567521b9fbfcc568#diff-22a320c218700276113cd8d961ef249f [2] https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-common/tasks/installs/install_on_redhat.yml#L71
Thanks for reporting this, here a patch upstream: https://github.com/ceph/ceph-ansible/pull/1557 Do you mind testing it? Thanks
I'm able to retest it only by using it in our automated workflow, where I initially discovered it. But it will not cover the whole patch, so I'm not sure if it is enough or not?
It looks like upstream fix is still under review. Seb, please resolve, test, and merge.
Yes Daniel, that should be enough, thanks. Ian, indeed we are still discussing the right approach, will probably merge this today and do the backport as well.
discussed at program meeting, expecting to be in ON_QA today
I retested it on our work-flow where I initially discovered this issue and it works as expected. # rpm -qa | grep ansible ansible-2.2.2.0-1.el7.noarch ceph-ansible-2.2.7-1.el7scon.noarch >> VERIFIED
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:1496
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days