Bug 1454423 - github link in gerrit webpage needs a better parser
Summary: github link in gerrit webpage needs a better parser
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: project-infrastructure
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nigel Babu
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-22 17:15 UTC by Shyamsundar
Modified: 2017-07-17 14:06 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-17 14:06:00 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Shyamsundar 2017-05-22 17:15:11 UTC 
Description of problem:
if anything appears as a #<num> it becomes a github issue link in gerrit web UI (example: https://review.gluster.org/#/c/17319/2)

Can this be corrected to use the same regex (if it is regex based i.e) that we use in rfc.sh or in https://github.com/gluster/glusterfs-patch-acceptance-tests/commit/955158e92f3664da6e3307f0096d67add5620c7c as appropriate.

Usage of #<num> to refer to comment # or bug # or such artifacts are common in commits, hence improving the parser would certainly help in this regard.
Comment 1 Nigel Babu 2017-07-17 04:45:07 UTC 
This should now be fixed. See: https://review.gluster.org/#/c/17180/
Comment 2 Shyamsundar 2017-07-17 14:02:54 UTC 
Checked the provided test commit and some other commits, looks good.

Marking VERIFIED
Note You need to log in before you can comment on or make changes to this bug.