Description of problem: If you edit a service dialog and change one element in a box, then click to a different element in the box and change it as well, then click cancel. The first element's changes will be saved and the second element will not. In other words, the service dialog is saving the current element when you switch to a new element. Version-Release number of selected component (if applicable): 5.7.1.3.20170221135006_818f133 Actual results: service dialog saves changes to current element when you switch to a new element and then click cancel. Expected results: all changes should be reverted since we never clicked the save button.
https://github.com/ManageIQ/manageiq-ui-classic/pull/1445
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/f2fefea679fc5be4db80cf4cb822c0da5f651a34 commit f2fefea679fc5be4db80cf4cb822c0da5f651a34 Author: Harpreet Kataria <hkataria> AuthorDate: Fri May 26 15:56:57 2017 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Fri May 26 15:56:57 2017 -0400 Rollback any changes to Dialog object when validating dialog elements. We need to update the actual Dialog object and it's child elements when edit is in progress, after user makes changes to any elements if they make selection in the tree, dialog is validated to make sure user does not try to leave the screen/node without adding valid data before they add/edit more child elements. Fix in this PR is rolling back any changes to actual dialog object after validating the Dialog to bring it back to it's original state to fix the issue. https://bugzilla.redhat.com/show_bug.cgi?id=1454428 .../miq_ae_customization_controller/dialogs.rb | 1 + .../dialogs_spec.rb | 27 ++++++++++++++++++---- 2 files changed, 23 insertions(+), 5 deletions(-)
Fixed in 5.9.0.4.20171024163837_ef71ea6