Bug 1454479 - ceph-deploy osd activate foo:/mydisk fails when /mydisk is a mount point
Summary: ceph-deploy osd activate foo:/mydisk fails when /mydisk is a mount point
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: ceph
Version: 25
Hardware: All
OS: All
unspecified
medium
Target Milestone: ---
Assignee: Boris Ranto
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-22 21:14 UTC by Al Stone
Modified: 2017-12-12 10:51 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-12 10:51:29 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Al Stone 2017-05-22 21:14:51 UTC
Description of problem:
When using "ceph-deploy osd activate foo:/mydisk", the command will fail because it cannot get "systemctl start ceph-osd@N" to start on the host foo.

Version-Release number of selected component (if applicable):
Latest f25

How reproducible:
100%

Steps to Reproduce:
1. On host foo, add a disk with one partition, and put an XFS file system in that partition.
2.  Mount the new file system on host foo; e.g., mount /dev/sdb1 /mydisk
3.  From the ceph admin node (not foo, in my case), run the command:
       ceph-deploy osd prepare foo:/mydisk
4.  From the ceph admin node, run the command:
       ceph-deploy osd activate foo:/mydisk

Actual results:
The activation step fails.  On further investigation, it is because systemd cannot start the ceph-osd@N service (N is the OSD number).  Digging a little deeper, the script /usr/lib/ceph/ceph-osd-prestart.sh is failing, causing the service start to fail.


Expected results:
Systemd starts up the ceph-osd@N service, and the new OSD joins the rest of the cluster.


Additional info:
There was new code added recently to /usr/lib/ceph/ceph-osd-prestart.sh:

   # assert data directory exists - see http://tracker.ceph.com/issues/17091
   if [ ! -d "$data" ]; then
       echo "OSD data directory $data does not exist; bailing out." 1>&2
       exit 1
   fi

The test "[ ! -d "$data" ]" fails when /mydisk is a mount point, or if it is a link to a mount point.  I can work around this problem by commenting out the above test -- at that point, the OSD starts up and works fine.

Comment 1 Dan Mick 2017-05-22 21:37:11 UTC
Is there an upstream bug for this?

Comment 2 Fedora End Of Life 2017-11-16 18:55:32 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 3 Fedora End Of Life 2017-12-12 10:51:29 UTC
Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.