Spec URL: https://www.rexursive.com/pub/grimmer-proggy-squaresz-fonts/grimmer-proggy-tinysz-fonts.spec SRPM URL: https://www.rexursive.com/pub/grimmer-proggy-squaresz-fonts/grimmer-proggy-squaresz-fonts-1.0-1.fc25.src.rpm Description: The proggy fonts are a set of fixed-width screen fonts that are designed for code listings. Proggy Square Slashed Zero is identical to Proggy Square but has a slashed zero instead of a dot. Fedora Account System Username: bojan
Hello, - You need to validate the appdata file. See https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage You need first: BuildRequires: libappstream-glib Then in %install or %check: appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/appdata/%{fontname}.metainfo.xml - It seems the spec file name is different from the Name:. Shouldn't it be grimmer-proggy-squaresz-fonts.spec instead of grimmer-proggy-tinysz-fonts.spec Rpmlint complains about this. Besides, I've looked at the website and "tiny" seems to be another font. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/grimmer-proggy-tinysz-fonts/review-grimmer- proggy-squaresz-fonts/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. fonts: [ ]: Run repo-font-audit on all fonts in package. Note: Test run failed → Tool is broken [x]: Run ttname on all fonts in package. Note: ttname analyze results in fonts/ttname.log. Rpmlint ------- Checking: grimmer-proggy-squaresz-fonts-1.0-1.fc28.noarch.rpm grimmer-proggy-squaresz-fonts-1.0-1.fc28.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Thank you very much for reviewing! I will address and repost the SRPM/spec files. I copied this from my existing package of tinysz font, so some of the stuff I obviously forgot to edit. :-)
Hopefully fixed package/spec here: https://www.rexursive.com/pub/grimmer-proggy-squaresz-fonts/grimmer-proggy-squaresz-fonts-1.0-2.fc26.src.rpm https://www.rexursive.com/pub/grimmer-proggy-squaresz-fonts/grimmer-proggy-squaresz-fonts.spec
Everything is good, package accepted.
(In reply to Robert-André Mauchin from comment #4) > Everything is good, package accepted. Thank you for the review!
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/grimmer-proggy-squaresz-fonts
Please re-open if necessary, but this appears to have been built.