Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1454590

Summary:	run.c demo mode broken
Product:	[Community] GlusterFS	Reporter:	Csaba Henk <csaba>
Component:	core	Assignee:	Csaba Henk <csaba>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.13.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-08 17:33:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Csaba Henk 2017-05-23 06:24:28 UTC

Description of problem:

run.c of libglusterfs should be possible to compile into a standalone object file or demo program, with, respectively, using the RUN_STANDALONE / RUN_DO_TESTS defines.




Version-Release number of selected component (if applicable):


How reproducible:

Always.

Steps to Reproduce:
1. $ cc -DRUN_STANDALONE -c run.c
2. $ cc -DRUN_DO_TESTS -o run run.c `pkg-config --libs --cflags glusterfs-api` && ./run
3. $ cc -DRUN_DO_TESTS -DRUN_STANDALONE -o run run.c && ./run

Actual results:

Each of the above commands fail.

Expected results:

Each of the above commands succeed, and in 2. and 3. the ./run invocations run with sane output.

Additional info:

Comment 1 Worker Ant 2017-05-23 06:32:35 UTC

REVIEW: https://review.gluster.org/17363 (libglusterfs: fix run.c demo mode) posted (#1) for review on master by Csaba Henk (csaba)

Comment 2 Worker Ant 2017-09-07 10:09:55 UTC

COMMIT: https://review.gluster.org/17363 committed in master by Amar Tumballi (amarts) 
------
commit b2902477414e5801f00a94b72cf0d0395297aa47
Author: Csaba Henk <csaba>
Date:   Tue May 23 08:27:06 2017 +0200

    libglusterfs: fix run.c demo mode
    
    run.c can be compiled into a standalone object file
    or a demo program with the appropriate defines for
    development purposes. This functionality was broken.
    
    We fix it and also clean it up:
    - call it "demo mode" not "test mode" as tests should
      come with verification of the results of the invocation
      which is not being done
    - add comments to the source explaining the feature
    - provide more comprehensive output in the demo program
    
    This change does not affect standard compilation and
    usage of run.c functionality.
    
    BUG: 1454590
    Change-Id: I1ea618e3262bf6a4d9f79f6b59209438d5163244
    Signed-off-by: Csaba Henk <csaba>
    Reviewed-on: https://review.gluster.org/17363
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: Amar Tumballi <amarts>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>

Comment 3 Shyamsundar 2017-12-08 17:33:42 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/