Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1454696

Summary:	vdsm-client uses unsecure instead of insecure
Product:	[oVirt] vdsm	Reporter:	Petr Matyáš <pmatyas>
Component:	Tools	Assignee:	Irit Goihman <igoihman>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Petr Matyáš <pmatyas>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.20.0	CC:	bugs, lsvaty, mperina, stirabos
Target Milestone:	ovirt-4.1.3	Flags:	rule-engine: ovirt-4.1+ lsvaty: testing_ack+
Target Release:	4.19.19
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-06 13:36:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Matyáš 2017-05-23 10:59:58 UTC

Description of problem:
I never heard of unsecure and everywhere is always used insecure, so I would rather see this changed to insecure, since this is a huge inconsistency.

Version-Release number of selected component (if applicable):
vdsm-4.20.0-878.git64a7b51.el7.centos.x86_64 but it's there since vdsm-client was introduced

How reproducible:
always

Steps to Reproduce:
1. man vdsm-client
2.
3.

Actual results:
unsecure option is present

Expected results:
it should be "insecure"

Additional info:

Comment 1 Yaniv Bronhaim 2017-05-23 12:21:14 UTC

sounds like doc fixes.. can be squeezed to 4.1.3 imo

Comment 2 Irit Goihman 2017-05-23 12:22:50 UTC

Hi Petr,
The change has been already merged: "unsecure" option is deprecated and the right option was introduced.

Comment 3 Petr Matyáš 2017-05-31 10:48:12 UTC

This is fixed in 'vdsm-client --help', but it's still missing in man pages.

Comment 4 Red Hat Bugzilla Rules Engine 2017-05-31 10:48:16 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 5 Irit Goihman 2017-06-05 11:23:42 UTC

Petr, what vdsm version have you checked?
There is no man page in 4.1, I've added it only now.

Comment 6 Petr Matyáš 2017-06-05 13:27:27 UTC

I checked 4.20.something (4.2 master) since I reported the bug for that version :)

Comment 7 Martin Perina 2017-06-05 16:44:22 UTC

(In reply to Petr Matyáš from comment #6)
> I checked 4.20.something (4.2 master) since I reported the bug for that
> version :)

IMO it's generally wrong, because the bug is targeted to 4.1, so it should be checked with 4.1 release.
But in this case I think it's good that we found out that man page is missing from 4.1 and added it by subsequent patch (and of course fixed in master).

Comment 8 Martin Perina 2017-06-14 13:32:27 UTC

Moving back to 4.1.3 as it's part of 4.19.19 build

Comment 9 Martin Perina 2017-06-16 17:05:58 UTC

Included in v4.19.19 tag, moving to ON_QA

Comment 10 Petr Matyáš 2017-06-19 12:46:59 UTC

Verified with vdsm-4.19.19-1.el7ev.x86_64 and vdsm-4.20.1-26.gitd624d2f.el7.centos.x86_64

Both man page and --help shows insecure now instead of unsecure.