Bug 1455215

This bugzilla has been removed from the release and needs to be reviewed and Triaged for another Target Release.

This bugzilla has been removed from the release and needs to be reviewed and Triaged for another Target Release.

The review already in trackers at https://review.openstack.org/#/c/462918/ adds the validation itself.

Also adding https://review.openstack.org/#/c/485184/ and the parent review https://review.openstack.org/#/c/474578/ to trackers now. They actually wire up the validation to be executed before and after the undercloud upgrade.

Moving back to assigned until those land.

the review at https://review.openstack.org/#/c/474578/ is ready to land and adds  validations that run at the end of the undercloud upgrade. It is blocked pending discussion about landing it or bumping to Q, because of the time it is landing. I updated the review with a case for landing it today, copy/pasting here as I'm out for a few days and in case anyone else picks this up and misses the gerrit comment:

So I'll try and make the case for landing this:

1. It is 'upgrade only'... The code added here to invoke and wait for the "post-upgrade" validations is only executed on upgrade. https://review.openstack.org/#/c/474578/11/instack_undercloud/undercloud.py@1673 

2. The validations will not fail an upgrade... When any validations fail, the error messages are collected and displayed, but there is no exception raised https://review.openstack.org/#/c/474578/11/instack_undercloud/undercloud.py@1458 (fail_on_error is false)

3. WRT "critical" - well it depends who you ask :). No, this is not in the critical path to a successful undercloud upgrade. However catching even some subset of problems at this point, before going on to upgrade your overcloud is a (very?) nice thing to have. 

The original request is tracked at https://bugzilla.redhat.com/show_bug.cgi?id=1455215 (about service status, but we landed a bunch of validations with florian. Three of those are post-upgrade see the commit message here for more info. The discussion about pre vs post upgrade validations is in this review discussion above, if you are interested (and there is a related pre upgrade validations in the related reviews. I don't expect that one to land for P, but I think this can). 

So this is a nice enhancement for the (undercloud) upgrade ... and so final reason is indeed this is upgrades related and as such has a legitimate reason for landing late (as usual I expect we will continue to have to land things into stable/pike once it is cut everywhere, for all the last bits anyway).

Finally for an example run see latest undercloud upgrades job at http://logs.openstack.org/78/474578/11/check/gate-tripleo-ci-centos-7-undercloud-upgrades-nv/0306ada/logs/var/log/undercloud_upgrade.txt.gz#_2017-08-16_13_02_03_000 

thanks,

moving this to POST and fixing reviews in trackers. The validations are wired into the (end of the) undercloud upgrade with https://review.openstack.org/#/c/474578/ which is now merged.

adding https://review.openstack.org/#/c/499116/ to trackers see discussion at http://lists.openstack.org/pipermail/openstack-dev/2017-August/121627.html

just posted http://lists.openstack.org/pipermail/openstack-dev/2017-September/121722.html adding here for reference thanks

According to our records, this should be resolved by openstack-tripleo-validations-7.4.2-1.el7ost.  This build is available now.

According to our records, this should be resolved by instack-undercloud-7.4.3-5.el7ost.  This build is available now.

The validator didn't report when the heat service was down on the undercloud. It ran for a very long time and eventually showed a success result when it was supposed to show failure. I'll attach a screenshot.

Created attachment 1454556 [details]
Validation with success status and a warning

Attached is a screenshot of the validator when the openstack-heat-engine.service is stopped. The output says: "Warning! The validation did not run on any host."