Bug 1455465 - Virt: blank template should be of 'server' type and not 'desktop' type.
Summary: Virt: blank template should be of 'server' type and not 'desktop' type.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Backend.Core
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ovirt-4.4.0
: ---
Assignee: Ryan Barry
QA Contact: Tamir
URL:
Whiteboard:
: 1388599 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-25 09:13 UTC by Yaniv Kaul
Modified: 2024-01-06 04:25 UTC (History)
9 users (show)

Fixed In Version: ovirt-engine-4.4.0_beta3 rhv-4.4.0-30
Doc Type: Enhancement
Doc Text:
In this release, the default "optimized for" value optimization type for bundled templates is now set to "Server".
Clone Of:
Environment:
Last Closed: 2020-05-20 20:00:23 UTC
oVirt Team: Virt
Embargoed:
rbarry: needinfo-
pm-rhel: ovirt-4.4+
mavital: testing_plan_complete?

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 93302 0 master MERGED backend: make the default template type Server 2020-12-09 21:27:39 UTC

Description Yaniv Kaul 2017-05-25 09:13:03 UTC 
Description of problem:
Today the blank template is using the desktop 'optimized for' value.
Should be server, as this is the common use case.
Comment 1 Sharon Gratch 2017-06-07 12:01:12 UTC 
Setting the Blank template "optimized for" value to 'Desktop' is done in dbscripts/data/01100_insert_vm_static.sql where we put '0' in DB for the vm_type field (instead of '1').

In addition to that, we currently set the default value of VmBase.vmType and also overridden in VmStatic.vmType to 'Desktop' as well. That causes the creation of the targeted VM via v2v to be 'optimized for' Desktop as well.

So fixing this bug should consider fixing those two places.
Comment 2 Michal Skrivanek 2017-08-22 09:19:04 UTC 
can you push such a small change?
Comment 3 Michal Skrivanek 2018-03-20 07:29:17 UTC 
Note that Blank doesn't have a cluster version and any change is applicable to all clusters immediately
Comment 5 Michal Skrivanek 2018-07-18 14:04:21 UTC 
(In reply to Michal Skrivanek from comment #3)
> Note that Blank doesn't have a cluster version and any change is applicable
> to all clusters immediately

because of that I would suggest to change that only when we drop the older ones to limit the scope.
Comment 6 Ryan Barry 2019-01-21 14:53:53 UTC 
Re-targeting to 4.3.1 since it is missing a patch, an acked blocker flag, or both
Comment 9 Steven Rosenberg 2019-08-21 07:32:56 UTC 
*** Bug 1388599 has been marked as a duplicate of this bug. ***
Comment 11 Tamir 2020-04-21 13:18:20 UTC 
Verified on 4.4.0-31 RHEL 8.2 (Both hosts and engine)

Steps:
First create data center and cluster

In Admin Portal:
2. Click "New" in VMs tab
3. Choose the cluster you created and the "Blank" template  and enter a VM name.
4. Verify that the "Optimized for" is selected as "Server"
5. Create the VM
6. Enter the VM's page and verify that the "Optimized for" is selected as "Server".

In VM Portal:
2. Click "Create new VM" 
3. Choose the cluster you created, "provision source" as template and the "Blank" template  and enter a VM name.
4. Verify that the "Optimized for" is selected as "Server"
5. Create the VM
6. Enter the VM's page and verify that the "Optimized for" is selected as "Server".

Actual Results:
All as expected the "Optimized for" is selected as "Server" by deafult.
Comment 12 Sandro Bonazzola 2020-05-20 20:00:23 UTC 
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Comment 13 Red Hat Bugzilla 2024-01-06 04:25:12 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days
Note You need to log in before you can comment on or make changes to this bug.