Description of problem: Upgrade ocp with upgrade_control_plane.yml and upgrade_nodes.yml in two phases, openshift_excluder is not enabled after upgrade completed. From upgrade logs, it shows that all tasks are not executed in $/playbooks/common/openshift-cluster/upgrades/upgrade_nodes.yml which included in /playbooks/common/openshift-cluster/upgrades/v3.6/upgrade_nodes.yml. Version-Release number of selected component (if applicable): atomic-openshift-utils-3.6.80-1.git.0.807fc98.el7.noarch How reproducible: always Steps to Reproduce: 1. install ocp3.5 without excluders installed(enable_excluders=false) 2. upgrade ocp3.5 to ocp3.6 in separate phases # ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_6/upgrade_control_plane.yml # ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_6/upgrade_nodes.yml 3. Actual results: Upgrade did not finish with openshift_excluder unenabled. Expected results: Upgrade succeed with excluders under right status. Additional info: Refer to logs
I see now: /playbooks/common/openshift-cluster/upgrades/upgrade_nodes.yml has - name: Drain and upgrade nodes hosts: oo_nodes_to_upgrade:!oo_masters_to_config which means if the master is node at the same time, the play is never run. Which means the excluder is never re-enabled.
Basically, noone should run the node upgrade play over a host that is a master. This needs to be checked before the node_upgrade.yml playbook is run.
Upstream PR: https://github.com/openshift/openshift-ansible/pull/4393
Version: atomic-openshift-utils-3.6.121-1.git.0.ed0b72c.el7.noarch Steps to Reproduce: 1. install ocp3.5 without excluders installed 2. upgrade ocp3.5 to ocp3.6 in separate phases # ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_6/upgrade_control_plane.yml # ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_6/upgrade_nodes.yml 3. Upgrade successfully with both of excluders installed and enabled rightly.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2017:1716