Bug 1455901

Initial licensecheck output:

$ licensecheck -r .
./.gitreview: *No copyright* UNKNOWN
./.testr.conf: *No copyright* UNKNOWN
./AUTHORS: *No copyright* UNKNOWN
./CONTRIBUTING.rst: *No copyright* UNKNOWN
./ChangeLog: *No copyright* UNKNOWN
./HACKING.rst: *No copyright* UNKNOWN
./LICENSE: *No copyright* Apache (v2.0)
./MANIFEST.in: *No copyright* UNKNOWN
./README.rst: *No copyright* UNKNOWN
./babel.cfg: *No copyright* UNKNOWN
./requirements.txt: *No copyright* UNKNOWN
./setup.cfg: *No copyright* Apache
./setup.py: Apache (v2.0) GENERATED FILE
./test-requirements.txt: *No copyright* UNKNOWN
./tox.ini: *No copyright* UNKNOWN
./os_traits/__init__.py: *No copyright* Apache (v2.0)
./doc/source/conf.py: *No copyright* Apache (v2.0)
./doc/source/contributing.rst: *No copyright* UNKNOWN
./doc/source/index.rst: *No copyright* UNKNOWN
./doc/source/installation.rst: *No copyright* UNKNOWN
./doc/source/readme.rst: *No copyright* UNKNOWN
./doc/source/usage.rst: *No copyright* UNKNOWN
./os_traits/misc/__init__.py: *No copyright* Apache (v2.0)
./os_traits/storage/disk.py: *No copyright* Apache (v2.0)
./os_traits/tests/base.py: Apache (v2.0)
./os_traits/tests/test_os_traits.py: *No copyright* Apache (v2.0)
./releasenotes/source/conf.py: *No copyright* Apache (v2.0) GENERATED FILE
./releasenotes/source/index.rst: *No copyright* UNKNOWN
./releasenotes/source/unreleased.rst: *No copyright* UNKNOWN
./os_traits/hw/cpu/x86.py: *No copyright* Apache (v2.0)
./os_traits/hw/nic/__init__.py: *No copyright* Apache (v2.0)
./os_traits/hw/nic/accel.py: *No copyright* Apache (v2.0)
./os_traits/hw/nic/dcb.py: *No copyright* Apache (v2.0)
./os_traits/hw/nic/offload.py: *No copyright* Apache (v2.0)
./os_traits/hw/nic/sriov.py: *No copyright* Apache (v2.0)

The package is licensed using the Apache 2.0 license.

SRPM from Delorean checks: http://46.231.132.68:8080/v1/AUTH_b50e80d3969f441a8b7b1fe831003e0a/rdoartifacts/70/6870/10/check/DLRN-rpmbuild/Z51af93d7417742cd833319c7a06268aa/artifacts/centos/repos/78/9c/789ce955eac04adb71ec5f2bc4890dd8c86c7ceb_dev/python-os-traits-0.3.1-0.20170601110340.789ce95.el7.centos.src.rpm

Review Link: https://review.rdoproject.org/r/6870

This is a formal RDO package review using fedora-review tool.
* Since I am using DLRN generated spec, we can ignore rpmlint changelog error.
* Rest is perfect.

This package is approved Now.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 2 files have unknown license. Detailed output of licensecheck
     in /home/vagrant/reviews/python-os-traits/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[-]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -os-traits , python2-os-traits-tests , python-os-traits-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_version 0.3.1
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python2-os-traits-0.3.1-0.20170601110340.789ce95.el7.centos.noarch.rpm
          python2-os-traits-tests-0.3.1-0.20170601110340.789ce95.el7.centos.noarch.rpm
          python-os-traits-doc-0.3.1-0.20170601110340.789ce95.el7.centos.noarch.rpm
          python-os-traits-0.3.1-0.20170601110340.789ce95.el7.centos.src.rpm
python2-os-traits.noarch: E: no-changelogname-tag
python2-os-traits-tests.noarch: E: no-changelogname-tag
python2-os-traits-tests.noarch: W: no-documentation
python-os-traits-doc.noarch: W: summary-not-capitalized C os-traits documentation
python-os-traits-doc.noarch: E: no-changelogname-tag
python-os-traits.src: E: no-changelogname-tag
python-os-traits.src: W: invalid-url Source0: os-traits-0.3.1-0.20170601110340.789ce95.tar.gz
4 packages and 0 specfiles checked; 4 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
python-os-traits-doc.noarch: W: summary-not-capitalized C os-traits documentation
python-os-traits-doc.noarch: E: no-changelogname-tag
python2-os-traits.noarch: E: no-changelogname-tag
python2-os-traits-tests.noarch: E: no-changelogname-tag
python2-os-traits-tests.noarch: W: no-documentation
3 packages and 0 specfiles checked; 3 errors, 2 warnings.



Requires
--------
python-os-traits-doc (rpmlib, GLIBC filtered):

python2-os-traits (rpmlib, GLIBC filtered):
    python(abi)
    python-pbr
    python-six

python2-os-traits-tests (rpmlib, GLIBC filtered):
    python(abi)
    python-oslotest
    python-subunit
    python-testrepository
    python-testscenarios
    python-testtools
    python2-os-traits



Provides
--------
python-os-traits-doc:
    python-os-traits-doc

python2-os-traits:
    python-os-traits
    python2-os-traits

python2-os-traits-tests:
    python2-os-traits-tests



Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -m dlrn-master -r -b 1455901
Buildroot used: dlrn-master
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

The package is now available from the RDO Trunk repo: https://trunk.rdoproject.org/centos7/current/