Bug 1457164 - bash-completion ships development files in the main package
Summary: bash-completion ships development files in the main package
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: bash-completion
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Siteshwar Vashisht
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1324593 (view as bug list)
Depends On:
Blocks: IoT base-minimization
TreeView+ depends on / blocked
 
Reported: 2017-05-31 08:48 UTC by Peter Robinson
Modified: 2024-03-18 17:30 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-15 14:34:09 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Peter Robinson 2017-05-31 08:48:07 UTC
bash-completion ships pkgconfig and cmake files in the main bash-completion package.

It's not clear they do anything as part of the core functionality but as a result (in partiicular the bash-completion.pc) the package pulls in other dependencies which in a lot of usecases superfluous to requirements.

Is there a reason they're not in a -devel package?

Comment 1 Yanko Kaneti 2017-05-31 09:54:06 UTC
See bug 1324593 - WONTFIXed
Not sure if any of the circumstances around it have changed since then

Comment 2 Peter Robinson 2017-05-31 10:54:29 UTC
I only see yum-utils mentioned there and it's no longer default or shipped.

Comment 3 Jan Kurik 2017-08-15 06:36:33 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle.
Changing version to '27'.

Comment 4 Peter Robinson 2018-05-20 10:15:18 UTC
Still an issue

Comment 5 Kamil Dudka 2018-05-21 07:33:37 UTC
*** Bug 1324593 has been marked as a duplicate of this bug. ***

Comment 8 Miro Hrončok 2024-02-20 14:38:49 UTC
Perhaps this should have been coordinated with the impacted packages.

$ rg 'pkg-config.+--variable=completionsdir'
rpm-specs/borgbackup.spec:#%define bash_compdir %(pkg-config --variable=completionsdir bash-completion)
rpm-specs/breezy.spec:bashcompdir=$(pkg-config --variable=completionsdir bash-completion)
rpm-specs/cmake.spec:%global bash_completionsdir %(pkg-config --variable=completionsdir bash-completion 2>/dev/null || echo '%{_datadir}/bash-completion/completions')
rpm-specs/conda.spec:%global bash_completionsdir %(pkg-config --variable=completionsdir bash-completion 2>/dev/null || echo '/etc/bash_completion.d')
rpm-specs/composer.spec:%global bashcompdir    %(pkg-config --variable=completionsdir bash-completion 2>/dev/null)
rpm-specs/cowsay.spec:%global compdir %(pkg-config --variable=completionsdir bash-completion)
rpm-specs/creds.spec:%global bashcompdir %(pkg-config --variable=completionsdir bash-completion)
rpm-specs/datamash.spec:pkg-config --variable=completionsdir bash-completion ||
rpm-specs/dracut.spec:            --bashcompletiondir=$(pkg-config --variable=completionsdir bash-completion) \
rpm-specs/eg.spec:bashcompdir=$(pkg-config --variable=completionsdir bash-completion || :)
rpm-specs/fail2ban.spec:COMPLETIONDIR=%{buildroot}$(pkg-config --variable=completionsdir bash-completion)
rpm-specs/fedpkg.spec:%define compdir %(pkg-config --variable=completionsdir bash-completion)
rpm-specs/git-annex.spec:bash_completion_dir=%{buildroot}$(pkg-config --variable=completionsdir bash-completion)
rpm-specs/glusterfs.spec:%global bashcompdir %(pkg-config --variable=completionsdir bash-completion 2>/dev/null)
rpm-specs/GMT.spec:%global completion_dir %(pkg-config --variable=completionsdir bash-completion)
rpm-specs/gromacs.spec:%define compdir %(pkg-config --variable=completionsdir bash-completion)
rpm-specs/kim-api.spec:%global b_compdir %(pkg-config --variable=completionsdir bash-completion)
rpm-specs/lynis.spec:%global bashcompdir %(pkg-config --variable=completionsdir bash-completion)
rpm-specs/maxima.spec:%global bash_completionsdir %(pkg-config --variable=completionsdir bash-completion 2>/dev/null || echo '/etc/bash_completion.d')
rpm-specs/mpc.spec:%global compdir %(pkg-config --variable=completionsdir bash-completion)
rpm-specs/mt-st.spec:COMPLETIONDIR=%{buildroot}$(pkg-config --variable=completionsdir bash-completion)
rpm-specs/ndctl.spec:%define bashcompdir %(pkg-config --variable=completionsdir bash-completion)
rpm-specs/nordugrid-arc.spec:%global _bashcompdir %(pkg-config --variable=completionsdir bash-completion 2>/dev/null || echo %{_sysconfdir}/bash_completion.d)
rpm-specs/pulseaudio.spec:%global bash_completionsdir %(pkg-config --variable=completionsdir bash-completion 2>/dev/null || echo '/etc/bash_completion.d')
rpm-specs/pybugz.spec:%global bash_cmpl_dir %(pkg-config --variable=completionsdir bash-completion)
rpm-specs/python-django.spec:bashcompdir=$(pkg-config --variable=completionsdir bash-completion)
rpm-specs/python-vitrageclient.spec:bashcompdir=$(pkg-config --variable=completionsdir bash-completion)
rpm-specs/reptyr.spec:%define bashcomp %(pkg-config --variable=completionsdir bash-completion)
rpm-specs/source-highlight.spec:bashcompdir=$(pkg-config --variable=completionsdir bash-completion)
rpm-specs/tig.spec:%global bash_completion_dir %(pkg-config --variable=completionsdir bash-completion || echo /etc/bash_completion.d)/
rpm-specs/vagrant.spec:%global bashcompletion_dir %(pkg-config --variable=completionsdir bash-completion 2> /dev/null || :)

Comment 9 Miro Hrončok 2024-02-20 15:18:37 UTC
And those are just packages that invoke it directly in the spec. There are others that will fail with cryptic errors like:

RPM build errors:
    File not found: /builddir/build/BUILDROOT/libstoragemgmt-1.9.8-6.fc41.x86_64/usr/share/bash-completion/completions/lsmcli


Note You need to log in before you can comment on or make changes to this bug.